fix: throw error if no translations were found

[yevheniyJ]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.90%. Comparing base (f742d84) to head (946d6fe).

Files	Patch %	Lines
...m/crowdin/cli/commands/actions/DownloadAction.java	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #824   +/-   ##
=========================================
  Coverage     65.90%   65.90%           
  Complexity     1514     1514           
=========================================
  Files           223      223           
  Lines          6160     6160           
  Branches        932      932           
=========================================
  Hits           4059     4059           
  Misses         1562     1562           
  Partials        539      539           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sbrandwoo]

Please can you consider reverting this change. We run crowdin-sync via the github action and now our jobs are failing with the following:

❌ Couldn't find any file to download. Since you are using the 'Skip untranslated files' option, please make sure you have fully translated files

There's no error here, everything is working as expected, but now the process is failing.

[ben-wharton]

As @sbrandwoo says, we run this workflow daily on >100 repos in our infra, and this caused many engineers to wonder why their builds appear to be failing (whereas really their translations just aren't ready yet).

[andrii-bodnar]

@sbrandwoo @ben-wharton Sorry for the inconvenience.

If the skip untranslated files option is enabled, we can probably still exit with code 0 as before. It looks like that would be pretty expected in this case.

@yevheniyJ, what do you think?

[yevheniyJ]

Agree, sorry for inconvenience. PR with fix is prepared #829
CC @andrii-bodnar

[andrii-bodnar]

@sbrandwoo @ben-wharton the new versions are already available:

https://github.com/crowdin/crowdin-cli/releases/tag/4.1.1
https://github.com/crowdin/github-action/releases/tag/v2.1.1