Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cache management headers in HTTP response #187

Closed
Bartvds opened this issue Oct 13, 2016 · 1 comment
Closed

No cache management headers in HTTP response #187

Bartvds opened this issue Oct 13, 2016 · 1 comment

Comments

@Bartvds
Copy link

Bartvds commented Oct 13, 2016

There are no cache headers set on the search results so the browser and caching layers could serve stale results, or do repeated calls for same term.

This can be worked around with some decorators in the urls.py or solved upstream but it feel like an oversight to have nothing in here. Maybe this should be configurable; depending on where you use this functionality you may want some or zero caching.

Note the admin (using django 1.9) sets Cache-Control: max-age=0, must-revalidate, no-store, no-cache; on it's own HTML output.

@crucialfelix
Copy link
Owner

Good idea, we should set http headers.

On Thu, Oct 13, 2016, 13:53 Bart van der Schoor notifications@github.com
wrote:

There are no cache headers set on the search results so the browser and
caching layers could serve stale results, or do repeated calls for same
term.

This can be worked around with some decorators in the urls.py or solved
upstream but it feel like an oversight to have nothing in here. Maybe this
should be configurable; depending on where you use this functionality you
may want some or zero caching.

Note the admin (using django 1.9) sets Cache-Control: max-age=0,
must-revalidate, no-store, no-cache; on it's own HTML output.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#187, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AANWcgTtr5elB5QDyLPBKq90IFP_Q8GPks5qzhungaJpZM4KVzD2
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants