Fix Lookup.get_objects for inherited models #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: django > 1.10 should/could use pk.related_field.to_python but earlier versions need to use pk.rel.field.to_python They may deprecate rel later but at least we now have test coverage for it.
Because it is now passing in a list of models, not a QuerySet during render() tests: force update to latest versions of each 1.x release Locally the test was not failing because tox was happy with 1.11.1 and the bug doesn't happen a later 1.11.x version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: django > 1.10 should/could use pk.related_field.to_python
but earlier versions need to use pk.rel.field.to_python
They may deprecate rel later but at least we now have test coverage for it.