-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove protocol from dynamically loaded urls. #54
Conversation
Remove protocol from dynamically loaded urls.
thanks! |
When this little thing could be expected on pypi? |
I just did a release a few days ago. I'm afraid for something as small as this its hard to justify doing a release. you're deploying something with https ? is the browser completely blocking these imports ? |
It's only used in admin page in my code, so i can simply ignore block on chrome browser side. I don't know if similar solution is available in other browsers, but i think that minor point update for such ugly bug is realy good justify for this. If someone have used your library on production - simply he will have unusable application for now, if is using (like most production applications) https as base protocol. |
pip install git+git://github.com/crucialfelix/django-ajax-selects.git@cd8cdaf |
Yes, i know this method. Other is to have own pypi-like server with higher priority index than pypi.python.org. |
Thanks for the fix. I suggest doing a point release as the current version is not functional in chrome. New deploys of our code (requirements file contains |
fair enough, 1.3.3 is out please double check it ! I am using git flow and for some reason it is failing to merge the release branch back to both develop and release. so I had to manually set the version numbers on both branches. I think its fine now and I think the pypi release is correct. let me know if its not. I'm hopping on a plane soon so quite busy. thanks ! |
Looks great. Thanks! Safe travels... |
Urls loaded dynamically should not have specified protocols.