Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove protocol from dynamically loaded urls. #54

Merged
merged 1 commit into from
Nov 12, 2013

Conversation

jellonek
Copy link
Contributor

Urls loaded dynamically should not have specified protocols.

crucialfelix added a commit that referenced this pull request Nov 12, 2013
Remove protocol from dynamically loaded urls.
@crucialfelix crucialfelix merged commit cd8cdaf into crucialfelix:develop Nov 12, 2013
@crucialfelix
Copy link
Owner

thanks!

@jellonek
Copy link
Contributor Author

When this little thing could be expected on pypi?

@jellonek jellonek deleted the develop branch November 12, 2013 13:18
@crucialfelix
Copy link
Owner

I just did a release a few days ago. I'm afraid for something as small as this its hard to justify doing a release.

you're deploying something with https ? is the browser completely blocking these imports ?

@jellonek
Copy link
Contributor Author

It's only used in admin page in my code, so i can simply ignore block on chrome browser side. I don't know if similar solution is available in other browsers, but i think that minor point update for such ugly bug is realy good justify for this.

If someone have used your library on production - simply he will have unusable application for now, if is using (like most production applications) https as base protocol.

@crucialfelix
Copy link
Owner

pip install git+git://github.com/crucialfelix/django-ajax-selects.git@cd8cdaf

@jellonek
Copy link
Contributor Author

Yes, i know this method. Other is to have own pypi-like server with higher priority index than pypi.python.org.
As i wrote earlier - for me (as i'm not using this in user accessible place) - solution is easy, permit in chrome untrusted downloads, only because of this library.

@arhpreston
Copy link

Thanks for the fix.

I suggest doing a point release as the current version is not functional in chrome. New deploys of our code (requirements file contains django-ajax-selects) are all missing key functionality.

@crucialfelix
Copy link
Owner

fair enough, 1.3.3 is out

please double check it ! I am using git flow and for some reason it is failing to merge the release branch back to both develop and release. so I had to manually set the version numbers on both branches. I think its fine now and I think the pypi release is correct. let me know if its not. I'm hopping on a plane soon so quite busy.

thanks !

@arhpreston
Copy link

Looks great. Thanks! Safe travels...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants