Allow partial TorchToTcp conversions using a whitelist
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjain-stanford
force-pushed
the
sambhav/torchtotcp
branch
from
1bc96af
to
5370f60
Compare
add private method move addPatternIfOpInConvertTorchOpsSet to utility function add back typeConverter add inline function in Utils.h update Misc patterns as well update elementwise
sjain-stanford
force-pushed
the
sambhav/torchtotcp
branch
from
5370f60
to
7a6d51d
Compare
sjain-stanford
changed the title
TorchToTcp conversions using a whitelist
sjain-stanford
force-pushed
the
sambhav/torchtotcp
branch
from
e7c5eb6
to
774bde8
Compare
sjain-stanford
force-pushed
the
sambhav/torchtotcp
branch
from
774bde8
to
7cc8bdd
Compare
zezhang
approved these changes
Nov 3, 2023
sanjoy
approved these changes
Nov 3, 2023
| patterns.add<ConvertAtenAtan2Op>(typeConverter, context); | ||
| ConversionTarget &target, const llvm::StringSet<> &convertTorchOpsSet) { | ||
|
|
||
| #define INSERT_ATEN_ELEMENTWISE_OP_PATTERN(ConvertAtenOpPattern, AtenOp) \ |
There was a problem hiding this comment.
I think you can reduce some duplication through token pasting:
#define INSERT_ATEN_ELEMENTWISE_OP_PATTERN(AtenOp) \
torch_to_tcp::addPatternIfOpInConvertTorchOpsSet<Convert ## AtenOp ## Pattern, \
AtenOp>( \
typeConverter, patterns, target, convertTorchOpsSet)
...
INSERT_ATEN_ELEMENTWISE_OP_PATTERN(AtenAtan2Op);
Same for the other macros.
There was a problem hiding this comment.
Good suggestion, done. I think this was applicable to just INSERT_ATEN_ELEMENTWISE_OP_PATTERN macro in Elementwise.cpp and INSERT_ATEN_MISC_OP_PATTERN macro in Misc.cpp. PLMK if I missed any other occurrence and I'll address in a follow-on.
srinathava
pushed a commit
to srinathava/mlir-tcp
that referenced
this pull request
Jun 24, 2024
[LLVM](https://github.com/llvm/llvm-project/tree/e5ed7b6e2fd368b722b6359556cd0125881e7638) (Feb 27) [StableHlo](https://github.com/openxla/stablehlo/tree/d214e2e2bd568a80a9f25515907b64dd7b98c538) (Mar 5) [Torch-MLIR](https://github.com/llvm/torch-mlir/tree/a86e89ecb5c7929a39a38743fb7cacadf1ff41bb) (Mar 4) [TCP](https://github.com/cruise-automation/mlir-tcp/tree/8d5d10e91e1afc9a5bb88ac647de4929fa31d735) (Mar 5) Disable the python related tests that use the hermetic python deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pass option to TorchToTcp accepting a set of op name strings as whitelist (for selective conversion). This allows flexibility with phase ordering of conversion passes in downstream pipelines.