Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rollup to 2.79.2: https://github.com/rollup/rollup/security/advisories/GHSA-gcx4-mw62-g8wm #938

Closed
wants to merge 1 commit into from

Conversation

sgasser
Copy link

@sgasser sgasser commented Oct 26, 2024

Bumps rollup from 2.78.1 to 2.79.2.

This solves the problem of this failed PR: #922 because pnpm-lock.yaml is not up to date with packages/vite-plugin/package.json

Copy link

changeset-bot bot commented Oct 26, 2024

⚠️ No Changeset found

Latest commit: 8382cdc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
vite-plugin-docs ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2024 0:00am

@sgasser
Copy link
Author

sgasser commented Oct 26, 2024

There are breaking changes in rollup 2.78.0+: rollup/rollup#4623

I have no idea how to resolve it correctly @jacksteamdev

@sgasser sgasser closed this Oct 26, 2024
@jacksteamdev
Copy link
Contributor

Thanks @sgasser for the PR! I've updated the original PR to fix the Rollup-Vite TS conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants