Skip to content
This repository has been archived by the owner on Sep 1, 2021. It is now read-only.

AvogadroUse.cmake now checks for Eigen3 before checking for Eigen2. #21

Merged
merged 1 commit into from
Aug 5, 2015

Conversation

psavery
Copy link
Contributor

@psavery psavery commented Aug 5, 2015

This is needed for some external plugins in light of some recent Eigen3 updates to avogadro.

ghutchis added a commit that referenced this pull request Aug 5, 2015
AvogadroUse.cmake now checks for Eigen3 before checking for Eigen2.
@ghutchis ghutchis merged commit 1a97078 into cryos:master Aug 5, 2015
@ghutchis
Copy link
Collaborator

ghutchis commented Aug 5, 2015

I assume this solves the problem you mentioned? Makes sense.

@psavery
Copy link
Contributor Author

psavery commented Aug 5, 2015

Yep! My extension used AvogadroUse.cmake to set up some of the include
directories and such. My extension was using eigen 2 instead of eigen3,
which was resulting in the symbol errors during runtime. I think this fixes
it.

By the way, have you noticed that since incorporating Eigen3 into avogadro
more, there are a LOT more warnings during compilation? Most of them are
enumeral mismatches in Eigen3 (and a lot of the warnings carry over to my
extension's compilation as well). I know they aren't essential, but it
might be nice if we could figure out how to eliminate some of them.

On Wed, Aug 5, 2015 at 5:32 PM, Geoff Hutchison notifications@github.com
wrote:

I assume this solves the problem you mentioned? Makes sense.


Reply to this email directly or view it on GitHub
#21 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants