This repository has been archived by the owner on Sep 1, 2021. It is now read-only.
Updated libmsym with the most recent libmsym patch that supports C++. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Also changed C-style designated initialization of structs to C++ style initialization of structs in symmetryextension.cpp (will not compile otherwise). Also deleted unused variables in symmetryextension.cpp to eliminate compiler warnings.
|
I've compiled avogadro with MSVC 2010 before. I can do it again sooner or later to see if it needs a flag as well... |
This was referenced Apr 27, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed C-style designated initialization of structs to C++ style initialization of structs in symmetryextension.cpp (will not compile otherwise). Also deleted unused variables in symmetryextension.cpp to eliminate compiler warnings. Added "-fPIC" flag for GNU compilers. May need to add flags for other compilers as well.