Skip to content
This repository has been archived by the owner on Jun 9, 2022. It is now read-only.

feat(base): use runtime base image variant #3

Merged
merged 2 commits into from
Jul 9, 2021
Merged

feat(base): use runtime base image variant #3

merged 2 commits into from
Jul 9, 2021

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jul 8, 2021 •
edited
Loading 

$ TAG=0.3.0 sh build.sh
...
$ podman images | grep base
quay.io/cryostat/cryostat-base                      latest                  b3a9fe86b761  2 minutes ago   382 MB
quay.io/cryostat/cryostat-base                      0.3.0                   b3a9fe86b761  2 minutes ago   382 MB
quay.io/cryostat/cryostat-base                      0.2.0                   7ab53fd4bef7  6 weeks ago     630 MB

I tested this out with a cryostat image built on top of this newer base and everything still looks green. Integration tests and smoketesting passes just fine. I had to microdnf install findutils into the image so that the Cryostat entrypoint.sh can use find still, otherwise it works out of the box.

@andrewazores andrewazores requested a review from ebaron July 8, 2021 23:50
@andrewazores andrewazores force-pushed the runtime-base branch 3 times, most recently from 386e4fa to 60d9ef1 Compare July 9, 2021 00:12
ebaron
ebaron previously approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it in OpenShift with the operator and no problems. This will be nice to have!

@andrewazores andrewazores changed the title Use runtime base image variant ci(base): use runtime base image variant Jul 9, 2021
@andrewazores andrewazores added the ci label Jul 9, 2021
@andrewazores andrewazores changed the title ci(base): use runtime base image variant feat(base): use runtime base image variant Jul 9, 2021
@andrewazores andrewazores merged commit 0b8bb8f into cryostatio:main Jul 9, 2021
@andrewazores andrewazores deleted the runtime-base branch July 9, 2021 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @ebaron