Skip to content

Commit

Permalink
build(deps): bump com.github.spotbugs:spotbugs-annotations from 4.8.3…
Browse files Browse the repository at this point in the history
… to 4.8.4 (#368)

* build(deps): bump com.github.spotbugs:spotbugs-maven-plugin

Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.8.2.0 to 4.8.3.1.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.8.2.0...spotbugs-maven-plugin-4.8.3.1)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump com.github.spotbugs:spotbugs-annotations

Bumps [com.github.spotbugs:spotbugs-annotations](https://github.com/spotbugs/spotbugs) from 4.8.3 to 4.8.4.
- [Release notes](https://github.com/spotbugs/spotbugs/releases)
- [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md)
- [Commits](spotbugs/spotbugs@4.8.3...4.8.4)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-annotations
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* add final finalize() method to avoid potential finalizer attack

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Azores <aazores@redhat.com>
  • Loading branch information
dependabot[bot] and andrewazores authored Apr 8, 2024
1 parent 57dbfed commit 067151f
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@
<org.apache.commons.text.version>1.11.0</org.apache.commons.text.version>
<org.jsoup.version>1.16.1</org.jsoup.version>

<com.github.spotbugs.version>4.8.3</com.github.spotbugs.version>
<com.github.spotbugs.plugin.version>4.8.2.0</com.github.spotbugs.plugin.version>
<com.github.spotbugs.version>4.8.4</com.github.spotbugs.version>
<com.github.spotbugs.plugin.version>4.8.3.1</com.github.spotbugs.plugin.version>
<org.junit.jupiter.version>5.10.2</org.junit.jupiter.version>
<org.hamcrest.version>2.2</org.hamcrest.version>
<org.mockito.version>5.2.0</org.mockito.version>
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/io/cryostat/core/agent/AgentJMXHelper.java
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ public void defineEventProbes(String xmlDescription) throws ProbeDefinitionExcep
}
}

@Override
protected final void finalize() {}

static class ProbeDefinitionException extends Exception {
ProbeDefinitionException(String message, Throwable e) {
super(message, e);
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/io/cryostat/core/agent/CapturedValue.java
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,9 @@ public void setConverter(String converter) {
this.converter = converter;
}

@Override
protected final void finalize() {}

protected void copyContentToWorkingCopy(CapturedValue copy) {
copy.name = name;
copy.description = description;
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/io/cryostat/core/agent/Event.java
Original file line number Diff line number Diff line change
Expand Up @@ -231,4 +231,7 @@ private Element buildMethodElement(Document document) {

return methodElement;
}

@Override
protected final void finalize() {}
}

0 comments on commit 067151f

Please sign in to comment.