feat(discovery): add new eventkind for modified state (#172)

cryostatio · Jan 13, 2023 · f5d52fe · f5d52fe
1 parent 867a959
commit f5d52fe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/main/java/io/cryostat/core/net/discovery/JvmDiscoveryClient.java b/src/main/java/io/cryostat/core/net/discovery/JvmDiscoveryClient.java
@@ -81,13 +81,11 @@ public void onDiscovery(DiscoveryEvent evt) {
                                         c -> c.accept(new JvmDiscoveryEvent(EventKind.LOST, desc)));
                                 break;
                             case CHANGED:
-                                eventListeners.forEach(
-                                        c -> c.accept(new JvmDiscoveryEvent(EventKind.LOST, desc)));
                                 eventListeners.forEach(
                                         c ->
                                                 c.accept(
                                                         new JvmDiscoveryEvent(
-                                                                EventKind.FOUND, desc)));
+                                                                EventKind.MODIFIED, desc)));
                                 break;
                             default:
                                 logger.error(
@@ -148,6 +146,6 @@ public DiscoveredJvmDescriptor getJvmDescriptor() {
     public enum EventKind {
         FOUND,
         LOST,
-        ;
+        MODIFIED;
     }
 }
diff --git a/src/test/java/io/cryostat/core/net/discovery/JvmDiscoveryClientTest.java b/src/test/java/io/cryostat/core/net/discovery/JvmDiscoveryClientTest.java
@@ -207,14 +207,11 @@ void testChangedEvent() throws IOException {
                             "com.example.Foo", "service:jmx:rmi:///jndi/rmi://foo:9091/jmxrmi");
             listener.onDiscovery(new DiscoveryEvent(DiscoveryEvent.Kind.CHANGED, discoverable));
 
-            MatcherAssert.assertThat(
-                    kinds, Matchers.equalTo(List.of(EventKind.LOST, EventKind.FOUND)));
+            MatcherAssert.assertThat(kinds, Matchers.equalTo(List.of(EventKind.MODIFIED)));
             MatcherAssert.assertThat(
                     jvms,
                     Matchers.equalTo(
-                            List.of(
-                                    new DiscoveredJvmDescriptor(discoverable.getPayload()),
-                                    new DiscoveredJvmDescriptor(discoverable.getPayload()))));
+                            List.of(new DiscoveredJvmDescriptor(discoverable.getPayload()))));
         }
     }