Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): should build cryostat3 as well as cryostat (2.x) #330

Merged
merged 1 commit into from
Jan 12, 2024
Merged

feat(ci): should build cryostat3 as well as cryostat (2.x) #330

merged 1 commit into from
Jan 12, 2024

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Jan 11, 2024

Fixes: #324

@aali309 aali309 added the feat New feature or request label Jan 11, 2024
@github-actions GitHub Actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-330-3888814cad647373356ff782b1c7fb623d24058d-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-330-3888814cad647373356ff782b1c7fb623d24058d-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-3888814cad647373356ff782b1c7fb623d24058d-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-3888814cad647373356ff782b1c7fb623d24058d-linux-arm64 sh smoketest.sh

@github-actions GitHub Actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-330-3888814cad647373356ff782b1c7fb623d24058d-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-330-3888814cad647373356ff782b1c7fb623d24058d-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-3888814cad647373356ff782b1c7fb623d24058d-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-3888814cad647373356ff782b1c7fb623d24058d-linux-arm64 sh smoketest.sh

@github-actions GitHub Actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-330-c811fcb0311da5d684f84f941d528e8a25305fd4-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-330-c811fcb0311da5d684f84f941d528e8a25305fd4-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-c811fcb0311da5d684f84f941d528e8a25305fd4-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-c811fcb0311da5d684f84f941d528e8a25305fd4-linux-arm64 sh smoketest.sh

@github-actions GitHub Actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-330-f68663a41234bf7a645f8f19089480f1fcce8719-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-330-f68663a41234bf7a645f8f19089480f1fcce8719-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-f68663a41234bf7a645f8f19089480f1fcce8719-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-f68663a41234bf7a645f8f19089480f1fcce8719-linux-arm64 sh smoketest.sh

@aali309 aali309 self-assigned this Jan 12, 2024
@aali309 aali309 changed the title feat(ci):CI should build cryostat3 as well as cryostat (2.x) feat(ci): should build cryostat3 as well as cryostat (2.x) Jan 12, 2024
@aali309 aali309 marked this pull request as ready for review January 12, 2024 15:10
@aali309 aali309 requested a review from andrewazores January 12, 2024 15:10
@github-actions GitHub Actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-330-f7edcc24e718612ecffa44e223b5ddb52bdef7b8-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-330-f7edcc24e718612ecffa44e223b5ddb52bdef7b8-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-f7edcc24e718612ecffa44e223b5ddb52bdef7b8-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-f7edcc24e718612ecffa44e223b5ddb52bdef7b8-linux-arm64 sh smoketest.sh

@aali309
Copy link
Contributor Author

aali309 commented Jan 12, 2024

the build for cryostat3 works well.
image

The failed test for cryostat build
image

@andrewazores
Copy link
Member

Hmm... that 2.5.0 build should work since cryostatio/cryostat@8ae79bc .

@aali309
Copy link
Contributor Author

aali309 commented Jan 12, 2024

It works here , that was on my local branch.

@github-actions GitHub Actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-330-65931f2109563394ffebf0ce9fde4cb76717d9c2-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-330-65931f2109563394ffebf0ce9fde4cb76717d9c2-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-65931f2109563394ffebf0ce9fde4cb76717d9c2-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-65931f2109563394ffebf0ce9fde4cb76717d9c2-linux-arm64 sh smoketest.sh

@aali309
Copy link
Contributor Author

aali309 commented Jan 12, 2024

image

@aali309 aali309 force-pushed the ci_build_cryostat3 branch from 1eb3170 to b4c42a9 Compare January 12, 2024 16:15
@github-actions GitHub Actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-330-b4c42a91a8d8898fd806337a38135e324fd53777-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-330-b4c42a91a8d8898fd806337a38135e324fd53777-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-b4c42a91a8d8898fd806337a38135e324fd53777-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-330-b4c42a91a8d8898fd806337a38135e324fd53777-linux-arm64 sh smoketest.sh

@andrewazores
Copy link
Member

I think either now or at some point in the near future, we will also want to update that ^ test image matrix to provide 3.0 test images, rather than 2.xs.

@andrewazores andrewazores merged commit e191d42 into cryostatio:main Jan 12, 2024
12 checks passed
@andrewazores andrewazores mentioned this pull request Jan 12, 2024
Closed
@aali309 aali309 deleted the ci_build_cryostat3 branch January 12, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees

@aali309 aali309

Labels
feat New feature or request safe-to-test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] CI should build cryostat3 as well as cryostat (2.x)
2 participants
@aali309 @andrewazores