-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): prepare 2.4.0 release #100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Judging by the release notes on that |
Upgrading that action should indeed fix it. I'll open a PR. |
andrewazores
force-pushed
the
ship-240
branch
from
December 7, 2023 21:56
39a5fc5
to
7f273f1
Compare
ebaron
approved these changes
Dec 7, 2023
Not sure why the CI is hanging now. |
It eventually timed out. https://github.com/cryostatio/cryostat-helm/actions/runs/7134459037/job/19429320884
|
It worked on a retry, maybe an infra issue. |
Tested locally seemed to also work. $ podman run -it --network host --workdir=/data \
--volume ~/.kube/config:/root/.kube/config:ro \
--volume $(pwd):/data quay.io/helmpack/chart-testing:latest
/data# ct install --target-branch cryostat-v2.4 --upgrade --namespace=helm-test --config ct.yaml
...output-omitted...
------------------------------------------------------------------------------------------------------------------------
✔︎ cryostat => (version: "0.4.0", path: "charts/cryostat")
------------------------------------------------------------------------------------------------------------------------
All charts installed successfully
/data # |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to cryostatio/cryostat#1695