minor cleanup

Signed-off-by: Andrew Azores <aazores@redhat.com>

src/main/java/io/cryostat/net/AgentConnection.java

@@ -171,12 +171,7 @@ public Optional<Document> getXml(String name, TemplateType type)
 
     @Override
     public boolean isConnected() {
-        try {
-            return client.ping().toCompletionStage().toCompletableFuture().get();
-        } catch (ExecutionException | InterruptedException e) {
-            logger.warn(e);
-            return false;
-        }
+        return true;
     }
 
     @Override

src/main/java/io/cryostat/net/TargetConnectionManager.java

@@ -227,7 +227,11 @@ private JFRConnection connect(ConnectionDescriptor connectionDescriptor) throws
         URI uri = URI.create(connectionDescriptor.getTargetId());
         String scheme = uri.getScheme();
         if (Set.of("http", "https", "cryostat-agent").contains(scheme)) {
-            return agentConnectionFactory.get().createConnection(uri);
+            AgentConnection agent = agentConnectionFactory.get().createConnection(uri);
+            // agent connections don't need to be opened and closed as each method call just maps to
+            // an HTTP request. This performs a basic HTTP GET to ensure the agent is reachable
+            agent.connect();
+            return agent;
         } else {
             try {
                 return attemptConnectAsJMXServiceURL(connectionDescriptor);

src/main/java/io/cryostat/net/web/WebServer.java

@@ -318,7 +318,9 @@ public String getAssetDownloadURL(ApiVersion apiVersion, String... pathSegments)
     }
 
     private String getTargetId(JFRConnection conn) throws IOException {
-        // TODO this is a hack
+        // TODO this is a hack, the JFRConnection interface should be refactored to expose a more
+        // general connection URL / targetId method since the JMX implementation is now only one
+        // possible implementation
         if (conn instanceof AgentConnection) {
             return ((AgentConnection) conn).getUri().toString();
         }