fix(httpapi): log more detail on HTTP API exceptions (#714)

cryostatio · Oct 12, 2021 · 19855bc · 19855bc
1 parent 2fd72d9
commit 19855bc
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/src/main/java/io/cryostat/net/web/WebServer.java b/src/main/java/io/cryostat/net/web/WebServer.java
@@ -125,10 +125,22 @@ public void start() throws FlightRecorderException, SocketException, UnknownHost
                         exception = new HttpStatusException(500, ctx.failure());
                     }
 
+                    String payload =
+                            exception.getPayload() != null
+                                    ? exception.getPayload()
+                                    : exception.getMessage();
                     if (!HttpStatusCodeIdentifier.isServerErrorCode(exception.getStatusCode())) {
-                        logger.warn(exception);
+                        logger.warn(
+                                "HTTP {}: {}\n{}",
+                                exception.getStatusCode(),
+                                payload,
+                                ExceptionUtils.getStackTrace(exception).trim());
                     } else {
-                        logger.error(exception);
+                        logger.error(
+                                "HTTP {}: {}\n{}",
+                                exception.getStatusCode(),
+                                payload,
+                                ExceptionUtils.getStackTrace(exception).trim());
                     }
 
                     if (exception.getStatusCode() == 401) {
@@ -153,11 +165,6 @@ public void start() throws FlightRecorderException, SocketException, UnknownHost
                                 .end(gson.toJson(resp));
                     } else {
                         // kept for V1 API handler compatibility
-                        String payload =
-                                exception.getPayload() != null
-                                        ? exception.getPayload()
-                                        : exception.getMessage();
-
                         if (ExceptionUtils.hasCause(exception, HttpStatusException.class)) {
                             payload +=
                                     " caused by " + ExceptionUtils.getRootCauseMessage(exception);