minor cleanup

Signed-off-by: Andrew Azores <aazores@redhat.com>
cryostatio · Mar 15, 2023 · 296c940 · 296c940
1 parent ac50f33
commit 296c940
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/main/java/io/cryostat/net/AgentClient.java b/src/main/java/io/cryostat/net/AgentClient.java
@@ -99,11 +99,9 @@ Future<MBeanMetrics> mbeanMetrics() {
         Future<HttpResponse<String>> f =
                 invoke(HttpMethod.GET, "/mbean-metrics", BodyCodec.string());
         return f.map(HttpResponse::body)
-                .map(
-                        s -> {
-                            logger.info("mbean response: {}", s);
-                            return gson.fromJson(s, MBeanMetrics.class);
-                        });
+                // uses Gson rather than Vertx's Jackson because Gson is able to handle MBeanMetrics
+                // with no additional fuss. Jackson complains about private final fields.
+                .map(s -> gson.fromJson(s, MBeanMetrics.class));
     }
 
     private <T> Future<HttpResponse<T>> invoke(HttpMethod mtd, String path, BodyCodec<T> codec) {
@@ -143,7 +141,7 @@ private <T> Future<HttpResponse<T>> invoke(HttpMethod mtd, String path, BodyCode
                                             promise.fail(ar.cause());
                                             return;
                                         }
-                                        logger.info(
+                                        logger.trace(
                                                 "{} {}{} status {}: {}",
                                                 mtd,
                                                 agentUri,

diff --git a/src/main/java/io/cryostat/net/AgentConnection.java b/src/main/java/io/cryostat/net/AgentConnection.java
@@ -184,9 +184,7 @@ public MBeanMetrics getMBeanMetrics()
             throws ConnectionException, IOException, InstanceNotFoundException,
                     IntrospectionException, ReflectionException {
         try {
-            var m = client.mbeanMetrics().toCompletionStage().toCompletableFuture().get();
-            logger.info("mbeans: {}", m);
-            return m;
+            return client.mbeanMetrics().toCompletionStage().toCompletableFuture().get();
         } catch (ExecutionException | InterruptedException e) {
             throw new IOException(e);
         }