minor cleanup

Signed-off-by: Andrew Azores <aazores@redhat.com>
cryostatio · Mar 16, 2023 · a457a03 · a457a03
1 parent 4f0e2aa
commit a457a03
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/main/java/io/cryostat/net/AgentConnection.java b/src/main/java/io/cryostat/net/AgentConnection.java
@@ -171,12 +171,7 @@ public Optional<Document> getXml(String name, TemplateType type)
 
     @Override
     public boolean isConnected() {
-        try {
-            return client.ping().toCompletionStage().toCompletableFuture().get();
-        } catch (ExecutionException | InterruptedException e) {
-            logger.warn(e);
-            return false;
-        }
+        return true;
     }
 
     @Override

diff --git a/src/main/java/io/cryostat/net/web/WebServer.java b/src/main/java/io/cryostat/net/web/WebServer.java
@@ -318,7 +318,9 @@ public String getAssetDownloadURL(ApiVersion apiVersion, String... pathSegments)
     }
 
     private String getTargetId(JFRConnection conn) throws IOException {
-        // TODO this is a hack
+        // TODO this is a hack, the JFRConnection interface should be refactored to expose a more
+        // general connection URL / targetId method since the JMX implementation is now only one
+        // possible implementation
         if (conn instanceof AgentConnection) {
             return ((AgentConnection) conn).getUri().toString();
         }