Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP 500 on timeout when requesting invalid URL on minimal image #627

Closed
andrewazores opened this issue Aug 5, 2021 · 0 comments · Fixed by #628
Closed

HTTP 500 on timeout when requesting invalid URL on minimal image #627

andrewazores opened this issue Aug 5, 2021 · 0 comments · Fixed by #628
Assignees
@andrewazores
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

If I accidentally send a request without a :targetId in the request URL, the server returns a 500. Should this be left as a 500 because the server doesn't know how to handle this URL or a 400 because the user entered a URL with a missing parameter?
eg GET /api/v2/targets/:targetId/recordingOptionsList:

curl -v --insecure https://0.0.0.0:8181/api/v2/targets/recordingOptionsList
...
< HTTP/1.1 500 Internal Server Error
< content-type: text/plain
< content-length: 74

Originally posted by @jan-law in cryostatio/cryostat#474 (comment)
@andrewazores andrewazores self-assigned this Aug 5, 2021
@andrewazores andrewazores added the bug Something isn't working label Aug 5, 2021
andrewazores added a commit to andrewazores/cryostat that referenced this issue Aug 5, 2021
@andrewazores
fix(webclientassets): produce 404 instead of 500 when minimal
b359799 
Fixes cryostatio#627
@andrewazores andrewazores mentioned this issue Aug 5, 2021
Merged
andrewazores added a commit that referenced this issue Aug 6, 2021
@andrewazores
fix(webclientassets): produce 404 instead of 500 when minimal (#628)
4e1dea1 
Fixes #627
tthvo pushed a commit to tthvo/cryostat-legacy that referenced this issue Dec 9, 2024
@dependabot
build(deps): bump org.codehaus.mojo:exec-maven-plugin from 3.3.0 to 3…
e4e659b 
….4.1 (cryostatio#627)

build(deps): bump org.codehaus.mojo:exec-maven-plugin

Bumps [org.codehaus.mojo:exec-maven-plugin](https://github.com/mojohaus/exec-maven-plugin) from 3.3.0 to 3.4.1.
- [Release notes](https://github.com/mojohaus/exec-maven-plugin/releases)
- [Commits](mojohaus/exec-maven-plugin@3.3.0...3.4.1)

---
updated-dependencies:
- dependency-name: org.codehaus.mojo:exec-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewazores andrewazores

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(webclientassets): produce 404 instead of 500 when minimal andrewazores/cryostat
1 participant
@andrewazores