Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datasource): enable overwrite and use hardcoded filename #1354

Merged
merged 3 commits into from
Feb 2, 2023
Merged

fix(datasource): enable overwrite and use hardcoded filename #1354

merged 3 commits into from
Feb 2, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Feb 2, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Related to cryostatio/jfr-datasource#153

Description of the change:

Routes that post jfr file to datasource should now use query paramter overwrite=true and hardcoded name cryostat-analysis.jfr.

Motivation for the change:

See https://github.com/cryostatio/jfr-datasource/issue/152

@tthvo tthvo added the fix label Feb 2, 2023
@mergify mergify bot added the safe-to-test label Feb 2, 2023
@tthvo tthvo marked this pull request as ready for review February 2, 2023 19:14
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1354-80cc134d99ca7939caed8529d093bbd770ce76e7 sh smoketest.sh

@andrewazores andrewazores merged commit 0285ffb into cryostatio:main Feb 2, 2023
@tthvo tthvo deleted the datasource-query branch February 2, 2023 19:44
@andrewazores andrewazores mentioned this pull request Feb 2, 2023
Closed
3 tasks
@andrewazores andrewazores mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

@maxcao13 maxcao13 Awaiting requested review from maxcao13

Assignees
No one assigned
Labels
fix safe-to-test
Projects
No open projects
2.3.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tthvo @andrewazores