Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(itests): Fixing integration tests after jmc core upgrade #1451

Closed
wants to merge 1 commit into from

Conversation

Josh-Matsuoka
Copy link
Contributor

@Josh-Matsuoka Josh-Matsuoka commented Apr 13, 2023

Fixes the integration tests after upgrading to jmc-core 8.2.0, there's an extra rule being run (the heap dump rule) so this adjusts the integration tests to check for it.

Depends on cryostatio/cryostat-core#201

@github-actions
Copy link
Contributor

This PR/issue depends on:

@andrewazores
Copy link
Member

After cryostatio/cryostat-core#201 is merged, Dependabot should open a PR on this repo (and -reports) to update the dependency. At that point we'll see the failing tests in the generated PR. I think I can just cherry-pick the commit from your PR here into that Dependabot PR so that the update and the test fix come in one changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants