Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(discovery): remove kubeenv discovery plugin #1475

Merged
merged 3 commits into from
Apr 25, 2023
Merged

chore(discovery): remove kubeenv discovery plugin #1475

merged 3 commits into from
Apr 25, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #1474

@mergify mergify bot added the safe-to-test label Apr 25, 2023
@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. backport labels Apr 25, 2023
@andrewazores andrewazores requested a review from ebaron April 25, 2023 20:37
ebaron
ebaron previously approved these changes Apr 25, 2023
View reviewed changes
@andrewazores andrewazores force-pushed the remove-kubeenv-discovery branch from da1ad35 to 119d452 Compare April 25, 2023 20:47
ebaron
ebaron previously approved these changes Apr 25, 2023
View reviewed changes
@andrewazores
Copy link
Member Author

Bah, need to rebase and re-sign the commit again. Hang on.

@andrewazores andrewazores force-pushed the remove-kubeenv-discovery branch from 119d452 to 2ec3db6 Compare April 25, 2023 20:54
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1475-2ec3db62e7974af00fe6b78d3cc10bbfaef0767d sh smoketest.sh

@andrewazores andrewazores merged commit 7b83be5 into cryostatio:main Apr 25, 2023
mergify bot pushed a commit that referenced this pull request Apr 25, 2023
@andrewazores @mergify
chore(discovery): remove kubeenv discovery plugin (#1475)
f790406 
* chore(discovery): remove kubeenv discovery plugin

* fixup! chore(discovery): remove kubeenv discovery plugin

* update README

(cherry picked from commit 7b83be5)
@mergify mergify bot mentioned this pull request Apr 25, 2023
Merged
ebaron pushed a commit that referenced this pull request Apr 25, 2023
@mergify @andrewazores
chore(discovery): remove kubeenv discovery plugin (#1475) (#1476)
891254d 
* chore(discovery): remove kubeenv discovery plugin

* fixup! chore(discovery): remove kubeenv discovery plugin

* update README

(cherry picked from commit 7b83be5)

Co-authored-by: Andrew Azores <aazores@redhat.com>
@andrewazores andrewazores deleted the remove-kubeenv-discovery branch April 26, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
backport chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
2.3.0 release
Status: Done
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Remove KubeEnv discovery plugin
2 participants
@andrewazores @ebaron