Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(agent): update agent template utilities #1563

Merged
merged 2 commits into from
Jun 23, 2023
Merged

chore(agent): update agent template utilities #1563

merged 2 commits into from
Jun 23, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Jun 22, 2023 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Depends on cryostatio/cryostat-core#241
Related to cryostatio/cryostat-core#239

Description of the change:

  • Update to use the latest core utilities.
  • Remove unused field in notifications (i.e. previously it holds the temporary uploaded filepath).

@tthvo tthvo added the chore Refactor, rename, cleanup, etc. label Jun 22, 2023
@tthvo tthvo requested review from andrewazores and maxcao13 June 22, 2023 08:15
@mergify mergify bot added the safe-to-test label Jun 22, 2023
@tthvo tthvo mentioned this pull request Jun 22, 2023
Merged
7 tasks
@maxcao13 maxcao13 mentioned this pull request Jun 22, 2023
Merged
@tthvo tthvo requested a review from ebaron as a code owner June 22, 2023 22:37
@github-actions
Copy link
Contributor

This PR/issue depends on:

maxcao13
maxcao13 reviewed Jun 22, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
Thuan Vo added 2 commits June 23, 2023 12:31
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1563-71e5c215c93fa8248b4c46808c84bf70810d8a09-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1563-71e5c215c93fa8248b4c46808c84bf70810d8a09-linux-arm64 sh smoketest.sh

@andrewazores andrewazores merged commit 293dabb into cryostatio:main Jun 23, 2023
mergify bot pushed a commit that referenced this pull request Jun 23, 2023
@mergify
fix(jmc-agent): fix template validation error handling and notificati…
47169c9 
…on content (#1563)

* chore(agent): update agent template utilities

Signed-off-by: Thuan Vo <thvo@redhat.com>

* deps(core): bump core version

---------

Signed-off-by: Thuan Vo <thvo@redhat.com>
(cherry picked from commit 293dabb)
@mergify mergify bot mentioned this pull request Jun 23, 2023
Merged
@andrewazores andrewazores added fix and removed chore Refactor, rename, cleanup, etc. labels Jun 23, 2023
andrewazores pushed a commit that referenced this pull request Jun 23, 2023
@mergify
fix(jmc-agent): fix template validation error handling and notificati…
9498ffd 
…on content (#1563) (#1564)

* chore(agent): update agent template utilities

Signed-off-by: Thuan Vo <thvo@redhat.com>

* deps(core): bump core version

---------

Signed-off-by: Thuan Vo <thvo@redhat.com>
(cherry picked from commit 293dabb)

Co-authored-by: Thuan Vo <thvo@redhat.com>
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1563-71e5c215c93fa8248b4c46808c84bf70810d8a09-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1563-71e5c215c93fa8248b4c46808c84bf70810d8a09-linux-arm64 sh smoketest.sh

@tthvo tthvo deleted the agent-template branch May 16, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcao13 maxcao13 maxcao13 left review comments

@andrewazores andrewazores andrewazores approved these changes

@ebaron ebaron Awaiting requested review from ebaron

Assignees
No one assigned
Labels
backport fix safe-to-test
Projects
No open projects
2.3.1 release
Status: Done
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tthvo @andrewazores @maxcao13