-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(contribute): update contributing guides #1726
docs(contribute): update contributing guides #1726
Conversation
Did not add the |
I thought if someone opened a PR and got the reviewers team to add the |
if that's the case, I should add the |
Here's the definition for what fails the |
The commenter must have author association of "member" or "owner": https://docs.github.com/en/graphql/reference/enums#commentauthorassociation Which means they are part of the org or own the repo - it's not clear to me from this if that means they own the upstream repo or if they own the fork that the PR was opened from. Perhaps it can be an external author here.
This clause looks like it restricts the command to the PR's author, but perhaps I'm misunderstanding. |
Yes, it appears the same to me. The |
Contradicting my previous understanding.. After reading, what I understood is that the term "OWNER" typically refers to the owner of the upstream repository where the actions are being triggered. Unfortunately, could not find clear documentation to clarify this. So I think the |
yea I thought it was the |
Looks like its correct tho. Here is the doc about And since the comment is made on upstream repo, I believe |
4a1979e
to
4a11ea1
Compare
I got distracted from this. So what conclusion do we come to - the |
No, I think the |
Okay, that's fine too. Maybe down the line it'll be worth trying to update that to allow any author so long as the PR has been labelled, but I think that's pretty low priority. On the other hand, maybe that ability should be locked down to only reviewers or at least members of the contributors team - people we recognize and already trust. |
4a11ea1
to
7b44806
Compare
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #1665
Description of the change:
updated CONTRIBUTING.md