Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(dependabot): request review for deps update from maintainers #1730

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Oct 19, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1660

Description of the change:

Update code owner to reference cryostat maintainers. This still asks review from reviewer team tho.

Motivation for the change:

See #1660

@tthvo tthvo added ci chore Refactor, rename, cleanup, etc. safe-to-test labels Oct 19, 2023
@github-actions
Copy link
Contributor

Hi @tthvo! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@tthvo tthvo requested a review from andrewazores October 19, 2023 07:10
@tthvo
Copy link
Member Author

tthvo commented Oct 19, 2023

This follows the pattern that was set up for operator in cryostatio/cryostat-operator#648. Or would u prefer to configure dependabot instead?

@andrewazores
Copy link
Member

I guess the dependabot configuration is actually just redundant - maybe we should have set it up so that dependabot just opens PRs without asking for review, and the CODEOWNERS file is what's responsible for requesting reviews. This way there is no duplicated policy, and the policy applies evenly regardless of whether the PR author is dependabot or some actual person.

@tthvo
Copy link
Member Author

tthvo commented Oct 19, 2023

Sounds good! Thanks! Updated now!

@andrewazores
Copy link
Member

One more rebase please.

@andrewazores andrewazores merged commit 46802fc into cryostatio:main Oct 19, 2023
7 checks passed
@tthvo tthvo deleted the dep-bot branch October 19, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. ci safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants