-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove String.format from logger calls to improve performance #363
Conversation
varargs? I believe the documentation specifies that this is how SLF4J does it - there are |
Should I add these methods for all of the logger message types even though some may not be used? |
They may not be used right now... IMO it only makes sense to make all of them consistent that way. |
yes, it makes sense, I added all the methods in cjfr-core, and changed the last string.format calls. |
Looks good. I manually rebased this and tested it myself and everything seems to continue working as expected. Please rebase this PR and I'll merge it. |
df4ba4b
to
86f8ef9
Compare
Fixes #358
There are two or three statements where I left the String.format call because they had several arguments, and it probably doesn't make sense to create functions for that exact number of objects in cjfr-core.