Loosen ServiceRef JMXServiceURL coupling #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use (absolute) URIs in most API touch-points rather than JMXServiceURLs to reduce coupling and ease future explorations for non-JMX connections
This was referenced Jun 17, 2021
jan-law
pushed a commit
to jan-law/cryostat
that referenced
this pull request
Jun 21, 2021
* Remove constructor * Remove another constructor * Loosen JMXServiceURL coupling Use (absolute) URIs in most API touch-points rather than JMXServiceURLs to reduce coupling and ease future explorations for non-JMX connections * Remove last JMXServiceURL-coupled constructor
jan-law
pushed a commit
to jan-law/cryostat
that referenced
this pull request
Jun 21, 2021
This reverts commit 946e959.
andrewazores
added a commit
to andrewazores/cryostat
that referenced
this pull request
Jun 24, 2021
* Remove constructor * Remove another constructor * Loosen JMXServiceURL coupling Use (absolute) URIs in most API touch-points rather than JMXServiceURLs to reduce coupling and ease future explorations for non-JMX connections * Remove last JMXServiceURL-coupled constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #520 #495 #280 #281
Use (absolute) URIs in most ServiceRef API touch-points rather than JMXServiceURLs to reduce coupling and ease future explorations for non-JMX connections. JMXServiceURLs are still required in other places, namely the TargetConnectionManager only knows how to deal with JMXServiceURLs.