Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fields for ServiceRefs #523

Merged
merged 10 commits into from
Jul 6, 2021

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jun 17, 2021

Rebased on top of #538

Fixes #280

Related to #495

Sample output from http :8181/api/v1/targets | jq:

[
  {
    "connectUrl": "service:jmx:rmi:///jndi/rmi://cryostat:9096/jmxrmi",
    "alias": "/deployments/quarkus-run.jar",
    "labels": {},
    "annotations": {
      "platform": {},
      "cryostat": {
        "HOST": "cryostat",
        "PORT": "9096",
        "JAVA_MAIN": "/deployments/quarkus-run.jar"
      }
    }
  },
  {
    "connectUrl": "service:jmx:rmi:///jndi/rmi://cryostat:9095/jmxrmi",
    "alias": "es.andrewazor.demo.Main",
    "labels": {},
    "annotations": {
      "platform": {},
      "cryostat": {
        "HOST": "cryostat",
        "PORT": "9095",
        "JAVA_MAIN": "es.andrewazor.demo.Main"
      }
    }
  }
]

@andrewazores andrewazores force-pushed the serviceref-extra-fields branch from a28d9c8 to 5d3a74c Compare July 2, 2021 17:33
@andrewazores andrewazores marked this pull request as ready for review July 2, 2021 17:33
@andrewazores andrewazores requested a review from ebaron July 2, 2021 18:13
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrewazores andrewazores merged commit f2c7e35 into cryostatio:main Jul 6, 2021
@andrewazores andrewazores deleted the serviceref-extra-fields branch July 6, 2021 15:56
aali309 pushed a commit to aali309/cryostat-legacy that referenced this pull request Jul 22, 2024
… 3.2.5 to 3.3.0 (cryostatio#523)

build(deps): bump org.apache.maven.plugins:maven-surefire-plugin

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.2.5 to 3.3.0.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.2.5...surefire-3.3.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional fields for ServiceRefs
2 participants