Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(itest): make test host configurable #573

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

andrewazores
Copy link
Member

Fixes #572

run.sh Show resolved Hide resolved
Add cryostat.itest.webHost property for configuring hostname webserver binds to and to which integration test requests are made, rather than hardcoding/assuming 0.0.0.0

Also replace some hardcoded references to port 8181 with existing cryostat.itest.webPort property
Copy link
Contributor

@hareetd hareetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrewazores andrewazores merged commit 385b98a into cryostatio:main Jul 15, 2021
@andrewazores andrewazores deleted the itest-web-host branch July 15, 2021 20:44
aali309 pushed a commit to aali309/cryostat-legacy that referenced this pull request Jul 22, 2024
….20-3.1721231685 in /src/main/docker (cryostatio#573)

build(deps): bump ubi8/openjdk-17-runtime in /src/main/docker

Bumps ubi8/openjdk-17-runtime from 1.20-3.1719963259 to 1.20-3.1721231685.

---
updated-dependencies:
- dependency-name: ubi8/openjdk-17-runtime
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

itests should not hardcode 0.0.0.0
3 participants