-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rules): implement "archive" rules #648
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
archive-rule
branch
from
August 18, 2021 16:43
f638be3
to
8872916
Compare
jan-law
reviewed
Aug 18, 2021
jan-law
reviewed
Aug 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
hareetd
reviewed
Aug 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
jan-law
approved these changes
Aug 19, 2021
tthvo
pushed a commit
to tthvo/cryostat-legacy
that referenced
this pull request
Dec 9, 2024
…ryostatio#648) Bumps [com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) from 9.40 to 9.41.1. - [Changelog](https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt) - [Commits](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.41.1..9.40) --- updated-dependencies: - dependency-name: com.nimbusds:nimbus-jose-jwt dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #645
Fixes #643
This implements an alternative and simplified version of the "one-shot" rules.
If a Rule definition is given where
"eventSpecifier":"archive"
, the rule definition will not be persisted, does not require a unique name, may not havearchivalPeriodSeconds/preservedArchives/maxAge/maxSize
, and rather than starting a new recording will cause a snapshot to be taken, copied to archives, and the snapshot immediately removed.The motivation is to allow a user to have a workflow such as the following:
Wait some time and observe application metrics (JFR or otherwise), either manually or by an external automated process. When some trigger event occurs, such as resource utilization exceeding a threshold for longer than some duration, the user wants to get copies of their application's JFR data at that moment and for the previous lookback window (5min in this case due to
maxAgeSeconds
).Note that this rule configuration gives the user a 5min window of data in the recording at any time, and that that 5 minute sample will be copied to archives only once per hour (3600 seconds). 6 such copies will be retained in the archives at any given time. Such a configuration could be used to gather ongoing continuous monitoring data, leaving long gaps in between archival periods to prevent excessive use of disk space, for example.
Alternatively, the rule definition may only start a continuous recording in the targets, without any configuration for periodic archiving.
After POSTing this second rule definition, Cryostat will connect to all of the same original set of targets and perform the snapshot/archive/remove snapshot procedure as explained earlier. The original recordings created by the first rule are still in place and running, so the user may re-POST the second rule definition as many times as they wish in the future as more external trigger events occur.