-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jmcagent): add API handlers for JMC agent plugin #731
feat(jmcagent): add API handlers for JMC agent plugin #731
Conversation
src/main/java/io/cryostat/net/web/http/api/beta/HttpApiBetaModule.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/net/web/http/api/beta/HttpApiBetaModule.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/net/web/http/api/beta/ProbeTemplateDeleteHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/net/web/http/api/beta/ProbeTemplateUploadHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/net/web/http/api/beta/ProbeTemplateUploadHandler.java
Show resolved
Hide resolved
Please rebase. This will also need an update to |
Not sure what that itest CI failure is exactly - some brief googling suggests that exit status 124 indicates that the command timed out. @Josh-Matsuoka could you also rebase this again? |
@andrewazores I've fixed the issue that was causing the itest container to fail to run, the current build failure is ReportJwtDownloadIT.testDownloadRecordingUsingJwt:72 which fails on a clean version of cryostat for me as well and seems to be unrelated to this PR. |
@Josh-Matsuoka please file a new issue for this test failure if there isn't one already, and include logs from both the frontend Maven test runner as well as the backend logs ( |
@Josh-Matsuoka rebase please |
https://github.com/cryostatio/cryostat/runs/4461031558?check_suite_focus=true#step:9:1392 Looks like this is #666, so it is indeed unrelated to this PR and has already been filed. |
CI is currently failing due to spotless formatting violation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the sanity check RuntimeException thing.
…a/container-jfr into agent-plugin-agent-handlers
Fixes #577
Fixes #578
Fixes #579
This PR adds jmc agent support to cryostat through a set of API handlers for managing probe templates (xml files detailing the desired transformations) as well as interacting with the agent (adding, removing, retrieving currently active event probes). Accompanying tests have been added. The CI failures should be resolved once the core support (cryostatio/cryostat-core#103) is integrated in core.