Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jmcagent): add API handlers for JMC agent plugin #731

Merged

Conversation

Josh-Matsuoka
Copy link
Contributor

@Josh-Matsuoka Josh-Matsuoka commented Oct 19, 2021

Fixes #577
Fixes #578
Fixes #579

This PR adds jmc agent support to cryostat through a set of API handlers for managing probe templates (xml files detailing the desired transformations) as well as interacting with the agent (adding, removing, retrieving currently active event probes). Accompanying tests have been added. The CI failures should be resolved once the core support (cryostatio/cryostat-core#103) is integrated in core.

@Josh-Matsuoka Josh-Matsuoka self-assigned this Oct 19, 2021
@Josh-Matsuoka Josh-Matsuoka marked this pull request as ready for review November 2, 2021 13:55
@andrewazores andrewazores self-requested a review November 2, 2021 17:40
@andrewazores andrewazores changed the title [WIP] Agent plugin agent handlers feat(jmcagent): add API handlers for JMC agent plugin Nov 2, 2021
@andrewazores andrewazores added the feat New feature or request label Nov 2, 2021
@andrewazores
Copy link
Member

Please rebase.

This will also need an update to pom.xml to use cryostat-core version 2.4.0 once it is tagged and released, as this will be the minor version update that includes the corresponding JMC Agent plugin classes. cryostatio/cryostat-core#104

@andrewazores
Copy link
Member

Not sure what that itest CI failure is exactly - some brief googling suggests that exit status 124 indicates that the command timed out. @Josh-Matsuoka could you also rebase this again?

@Josh-Matsuoka
Copy link
Contributor Author

@andrewazores I've fixed the issue that was causing the itest container to fail to run, the current build failure is

ReportJwtDownloadIT.testDownloadRecordingUsingJwt:72

which fails on a clean version of cryostat for me as well and seems to be unrelated to this PR.

@andrewazores
Copy link
Member

@Josh-Matsuoka please file a new issue for this test failure if there isn't one already, and include logs from both the frontend Maven test runner as well as the backend logs (target/cryostat-itest-sometimestamp.log, or the print itest logs task in the CI run)

@andrewazores
Copy link
Member

@Josh-Matsuoka rebase please

@andrewazores
Copy link
Member

@Josh-Matsuoka please file a new issue for this test failure if there isn't one already, and include logs from both the frontend Maven test runner as well as the backend logs (target/cryostat-itest-sometimestamp.log, or the print itest logs task in the CI run)

https://github.com/cryostatio/cryostat/runs/4461031558?check_suite_focus=true#step:9:1392

Looks like this is #666, so it is indeed unrelated to this PR and has already been filed.

@andrewazores
Copy link
Member

CI is currently failing due to spotless formatting violation

run.sh Outdated Show resolved Hide resolved
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the sanity check RuntimeException thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
2 participants