fix(rules): do not create cached connections for automated rules #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
requested review from
jan-law and
hareetd
and removed request for
jan-law
andrewazores
force-pushed
the
close-rules-connections
branch
2 times, most recently
from
c40e650 to
9fea079
Compare
hareetd
reviewed
Dec 2, 2021
|
Tests failed: https://github.com/cryostatio/cryostat/runs/4400157843?check_suite_focus=true#step:8:1578 Looks the same as #767 |
|
Hmm, that test keeps failing. I'll take a closer look at it. For now I'll mark this as a draft again while I investigate. |
Remove connection cache size/TTL config, which used an incorrect/outdated cache max size env var name, to better reflect a standard Cryostat deployment using default cache settings (unlimited size, 10s TTL) Fixes cryostatio#762
Related to cryostatio#756 Automated rules processing will reuse existing cached connections if available. If none are available then a new connection will be created and NOT cached, in order to avoid automated rules causing evictions of cached connections for other interactive clients
andrewazores
force-pushed
the
close-rules-connections
branch
from
a5d8ca1 to
24aa160
Compare
|
I think I've sorted out the failing test now. |
jan-law
reviewed
Dec 7, 2021
hareetd
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(rules): signal connections opened by rules may be immediately closed
Related to #756
fix(pom): remove itest connection cache size config
Remove connection cache size/TTL config, which used an incorrect/outdated
cache max size env var name, to better reflect a standard Cryostat
deployment using default cache settings (unlimited size, 10s TTL)
Fixes #762
fix(rules): do not create cached connections for automated rules
Related to #756
Automated rules processing will reuse existing cached connections if
available. If none are available then a new connection will be created and
NOT cached, in order to avoid automated rules causing evictions of cached
connections for other interactive clients