-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vertx): deploy verticles with async decorated blocking handlers #930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described for me. With just the block handler, the health check is blocked. With the fix, the health check doesn't block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me
0566c07
to
d9726a3
Compare
Just replaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Web-client is working well too with the changes.
Fixes #929
The first commit in this series is just for testing purposes. It adds an API handler at "/api/beta/block" that sleeps the current thread for 5 seconds, then returns a "hello" string response.
This can be used to test by doing:
in one terminal. In a second terminal, before that first request completes,
In current
main
, the/health
request will not return until after the/block
request returns. After the fix in this PR is applied these requests are properly handled concurrently again.