build(base): inline base img into build #982

andrewazores · 2022-06-06T23:32:38Z

Fixes cryostatio/cryostat-base#14

github-actions · 2022-06-06T23:32:51Z

Hi @andrewazores! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

github-actions · 2022-06-06T23:32:52Z

Hi @andrewazores! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

github-actions · 2022-06-06T23:32:52Z

Hi @andrewazores! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

andrewazores · 2022-06-06T23:35:43Z

@ebaron should we edit that GitHub Workflow config file to add a "build" semantic label? Assuming this will play nice with the automatic release drafter.

andrewazores · 2022-06-06T23:41:39Z

Ah, that new podman-maven-plugin I added is making the CI fail because it wants to have credentials to push to quay.io, even though it isn't actually configured to run its push goal. That's annoying.

That plugin is doing two things:

Doing a little bit of convenience to wrap around podman commands, so I don't have to always use the exec-maven-plugin for everything. But this doesn't go as far as I'd hoped, because Jib doesn't know how to read from the Podman registry without a daemon running. So the next best thing I can do is have Jib read the base image from a tarball, but the save goal from this Podman plugin doesn't let me save the tarball in the correct format that Jib expects. I'm doing podman save using the exec plugin in the end, anyway.
It reads the Containerfile and does Maven property filtering on it before passing it on to the podman build step, which is neat - it means that the ubi8 base image/tag can be defined in the pom.xml, rather than in the Containerfile. We could hack around this with the exec plugin too, though.

Worth dropping the podman-maven-plugin I guess.

ebaron · 2022-06-07T14:24:51Z

@ebaron should we edit that GitHub Workflow config file to add a "build" semantic label? Assuming this will play nice with the automatic release drafter.

Absolutely. I like using build to describe build-related changes as well. So I often have to add some alternative label to make the semantic labels job happy.

andrewazores · 2022-06-07T14:29:49Z

@ebaron should we edit that GitHub Workflow config file to add a "build" semantic label? Assuming this will play nice with the automatic release drafter.

Absolutely. I like using build to describe build-related changes as well. So I often have to add some alternative label to make the semantic labels job happy.

https://github.com/cryostatio/cryostat/issues/983

ebaron

Hey Andrew, looks good overall. Would you also be able to update the assembly descriptor under /src/assembly/dist.xml? We need to remove cryostat.jfc from the src/main/extras fileSet and probably just add another fileSet to include the whole src/container/include directory.

allows UBI image stream and tag to be defined in pom

andrewazores · 2022-06-08T18:34:37Z

How should I verify the results of updating the dist.xml?

ebaron · 2022-06-08T18:36:55Z

Just run mvn -Pdist package. The tarball should be under target/.

andrewazores · 2022-06-08T18:54:59Z

Here are the results of producing and then extracting the tarball.

Before PR:

$ tree cryostat-2.2.0-SNAPSHOT
cryostat-2.2.0-SNAPSHOT
├── app
│   ├── entrypoint.sh
│   ├── libs
│   │   ├── antlr4-runtime-4.9.2.jar
│   │   ├── automaton-1.11-8.jar
│   │   ├── bcprov-jdk15on-1.69.jar
│   │   ├── caffeine-3.0.1.jar
│   │   ├── common-7.1.1.jar
│   │   ├── commons-beanutils-1.9.4.jar
│   │   ├── commons-codec-1.15.jar
│   │   ├── commons-collections-3.2.2.jar
│   │   ├── commons-digester-2.1.jar
│   │   ├── commons-io-2.8.0.jar
│   │   ├── commons-lang3-3.12.0.jar
│   │   ├── commons-logging-1.2.jar
│   │   ├── commons-validator-1.7.jar
│   │   ├── cryostat-2.2.0-SNAPSHOT.jar
│   │   ├── cryostat-core-2.10.0.jar
│   │   ├── dagger-2.34.1.jar
│   │   ├── encoder-1.2.2.jar
│   │   ├── flightrecorder-7.1.1.jar
│   │   ├── flightrecorder.rules-7.1.1.jar
│   │   ├── flightrecorder.rules.jdk-7.1.1.jar
│   │   ├── generex-1.0.2.jar
│   │   ├── graphql-java-17.3.jar
│   │   ├── graphql-java-extended-scalars-17.0.jar
│   │   ├── gson-2.8.9.jar
│   │   ├── httpclient-4.5.13.jar
│   │   ├── httpcore-4.4.13.jar
│   │   ├── jackson-annotations-2.11.2.jar
│   │   ├── jackson-core-2.11.2.jar
│   │   ├── jackson-databind-2.11.2.jar
│   │   ├── jackson-dataformat-yaml-2.11.2.jar
│   │   ├── jackson-datatype-jsr310-2.11.2.jar
│   │   ├── java-dataloader-3.1.0.jar
│   │   ├── javax.inject-1.jar
│   │   ├── jcip-annotations-1.0-1.jar
│   │   ├── jsoup-1.14.2.jar
│   │   ├── kubernetes-client-5.4.1.jar
│   │   ├── kubernetes-model-admissionregistration-5.4.1.jar
│   │   ├── kubernetes-model-apiextensions-5.4.1.jar
│   │   ├── kubernetes-model-apps-5.4.1.jar
│   │   ├── kubernetes-model-autoscaling-5.4.1.jar
│   │   ├── kubernetes-model-batch-5.4.1.jar
│   │   ├── kubernetes-model-certificates-5.4.1.jar
│   │   ├── kubernetes-model-common-5.4.1.jar
│   │   ├── kubernetes-model-coordination-5.4.1.jar
│   │   ├── kubernetes-model-core-5.4.1.jar
│   │   ├── kubernetes-model-discovery-5.4.1.jar
│   │   ├── kubernetes-model-events-5.4.1.jar
│   │   ├── kubernetes-model-extensions-5.4.1.jar
│   │   ├── kubernetes-model-flowcontrol-5.4.1.jar
│   │   ├── kubernetes-model-metrics-5.4.1.jar
│   │   ├── kubernetes-model-networking-5.4.1.jar
│   │   ├── kubernetes-model-node-5.4.1.jar
│   │   ├── kubernetes-model-policy-5.4.1.jar
│   │   ├── kubernetes-model-rbac-5.4.1.jar
│   │   ├── kubernetes-model-scheduling-5.4.1.jar
│   │   ├── kubernetes-model-storageclass-5.4.1.jar
│   │   ├── logging-interceptor-3.12.12.jar
│   │   ├── netty-buffer-4.1.74.Final.jar
│   │   ├── netty-codec-4.1.74.Final.jar
│   │   ├── netty-codec-dns-4.1.74.Final.jar
│   │   ├── netty-codec-http2-4.1.74.Final.jar
│   │   ├── netty-codec-http-4.1.74.Final.jar
│   │   ├── netty-codec-socks-4.1.74.Final.jar
│   │   ├── netty-common-4.1.74.Final.jar
│   │   ├── netty-handler-4.1.74.Final.jar
│   │   ├── netty-handler-proxy-4.1.74.Final.jar
│   │   ├── netty-resolver-4.1.74.Final.jar
│   │   ├── netty-resolver-dns-4.1.74.Final.jar
│   │   ├── netty-tcnative-classes-2.0.48.Final.jar
│   │   ├── netty-transport-4.1.74.Final.jar
│   │   ├── nimbus-jose-jwt-9.16.1.jar
│   │   ├── okhttp-3.12.12.jar
│   │   ├── okio-1.15.0.jar
│   │   ├── openshift-client-5.4.1.jar
│   │   ├── openshift-model-5.4.1.jar
│   │   ├── openshift-model-console-5.4.1.jar
│   │   ├── openshift-model-monitoring-5.4.1.jar
│   │   ├── openshift-model-operator-5.4.1.jar
│   │   ├── openshift-model-operatorhub-5.4.1.jar
│   │   ├── reactive-streams-1.0.3.jar
│   │   ├── slf4j-api-1.7.30.jar
│   │   ├── slf4j-jdk14-1.7.30.jar
│   │   ├── snakeyaml-1.26.jar
│   │   ├── vertx-auth-common-4.2.5.jar
│   │   ├── vertx-bridge-common-4.2.5.jar
│   │   ├── vertx-core-4.2.5.jar
│   │   ├── vertx-web-4.2.5.jar
│   │   ├── vertx-web-client-4.2.5.jar
│   │   ├── vertx-web-common-4.2.5.jar
│   │   ├── vertx-web-graphql-4.2.5.jar
│   │   └── zjsonpatch-0.3.0.jar
│   └── resources
│       └── io
│           └── cryostat
│               ├── net
│               │   └── web
│               │       ├── app.bundle.js
│               │       ├── app.css
│               │       ├── cryostat-3-icon-16px.png
│               │       ├── fonts
│               │       │   ├── overpass-bold-italic.woff
│               │       │   ├── overpass-bold-italic.woff2
│               │       │   ├── overpass-bold.woff
│               │       │   ├── overpass-bold.woff2
│               │       │   ├── overpass-extrabold-italic.woff
│               │       │   ├── overpass-extrabold-italic.woff2
│               │       │   ├── overpass-extrabold.woff
│               │       │   ├── overpass-extrabold.woff2
│               │       │   ├── overpass-extralight-italic.woff
│               │       │   ├── overpass-extralight-italic.woff2
│               │       │   ├── overpass-extralight.woff
│               │       │   ├── overpass-extralight.woff2
│               │       │   ├── overpass-heavy-italic.woff
│               │       │   ├── overpass-heavy-italic.woff2
│               │       │   ├── overpass-heavy.woff
│               │       │   ├── overpass-heavy.woff2
│               │       │   ├── overpass-italic.woff
│               │       │   ├── overpass-italic.woff2
│               │       │   ├── overpass-light-italic.woff
│               │       │   ├── overpass-light-italic.woff2
│               │       │   ├── overpass-light.woff
│               │       │   ├── overpass-light.woff2
│               │       │   ├── overpass-mono-bold.woff
│               │       │   ├── overpass-mono-bold.woff2
│               │       │   ├── overpass-mono-light.woff
│               │       │   ├── overpass-mono-light.woff2
│               │       │   ├── overpass-mono-regular.woff
│               │       │   ├── overpass-mono-regular.woff2
│               │       │   ├── overpass-mono-semibold.woff
│               │       │   ├── overpass-mono-semibold.woff2
│               │       │   ├── overpass-regular.woff
│               │       │   ├── overpass-regular.woff2
│               │       │   ├── overpass-semibold-italic.woff
│               │       │   ├── overpass-semibold-italic.woff2
│               │       │   ├── overpass-semibold.woff
│               │       │   ├── overpass-semibold.woff2
│               │       │   ├── overpass-thin-italic.woff
│               │       │   ├── overpass-thin-italic.woff2
│               │       │   ├── overpass-thin.woff
│               │       │   ├── overpass-thin.woff2
│               │       │   ├── pficon.woff
│               │       │   ├── pficon.woff2
│               │       │   ├── RedHatDisplay-Bold.woff
│               │       │   ├── RedHatDisplay-Bold.woff2
│               │       │   ├── RedHatDisplay-Medium.woff
│               │       │   ├── RedHatDisplay-Medium.woff2
│               │       │   ├── RedHatDisplay-Regular.woff
│               │       │   ├── RedHatDisplay-Regular.woff2
│               │       │   ├── RedHatText-Medium.woff
│               │       │   ├── RedHatText-Medium.woff2
│               │       │   ├── RedHatText-Regular.woff
│               │       │   └── RedHatText-Regular.woff2
│               │       ├── HTTP_API.md
│               │       ├── images
│               │       │   ├── logo-cryostat-3-horizontal.svg
│               │       │   ├── logo-cryostat-3.svg
│               │       │   ├── pfbg_2000.jpg
│               │       │   ├── pfbg_576@2x.jpg
│               │       │   ├── pfbg_576.jpg
│               │       │   ├── pfbg_768@2x.jpg
│               │       │   ├── pfbg_768.jpg
│               │       │   └── pfbg_992@2x.jpg
│               │       ├── index.html
│               │       ├── npm.attr-accept.bundle.js
│               │       ├── npm.file-selector.bundle.js
│               │       ├── npm.focus-trap.bundle.js
│               │       ├── npm.history.bundle.js
│               │       ├── npm.hoist-non-react-statics.bundle.js
│               │       ├── npm.js-base64.bundle.js
│               │       ├── npm.lodash.bundle.js
│               │       ├── npm.mini-create-react-context.bundle.js
│               │       ├── npm.nanoid.bundle.js
│               │       ├── npm.object-assign.bundle.js
│               │       ├── npm.patternfly.bundle.js
│               │       ├── npm.patternfly.css
│               │       ├── npm.prop-types.bundle.js
│               │       ├── npm.react.bundle.js
│               │       ├── npm.react-dom.bundle.js
│               │       ├── npm.react-dropzone.bundle.js
│               │       ├── npm.react-is.bundle.js
│               │       ├── npm.react-router.bundle.js
│               │       ├── npm.react-router-dom.bundle.js
│               │       ├── npm.react-router-last-location.bundle.js
│               │       ├── npm.resolve-pathname.bundle.js
│               │       ├── npm.rxjs.bundle.js
│               │       ├── npm.scheduler.bundle.js
│               │       ├── npm.tabbable.bundle.js
│               │       ├── npm.tiny-invariant.bundle.js
│               │       ├── npm.tslib.bundle.js
│               │       ├── npm.value-equal.bundle.js
│               │       └── runtime.bundle.js
│               └── version
└── cryostat.jfc

9 directories, 187 files

After PR:

$ tree cryostat-2.2.0-SNAPSHOT
cryostat-2.2.0-SNAPSHOT
├── app
│   ├── entrypoint.sh
│   ├── libs
│   │   ├── antlr4-runtime-4.9.2.jar
│   │   ├── automaton-1.11-8.jar
│   │   ├── bcprov-jdk15on-1.69.jar
│   │   ├── caffeine-3.0.1.jar
│   │   ├── common-7.1.1.jar
│   │   ├── commons-beanutils-1.9.4.jar
│   │   ├── commons-codec-1.15.jar
│   │   ├── commons-collections-3.2.2.jar
│   │   ├── commons-digester-2.1.jar
│   │   ├── commons-io-2.8.0.jar
│   │   ├── commons-lang3-3.12.0.jar
│   │   ├── commons-logging-1.2.jar
│   │   ├── commons-validator-1.7.jar
│   │   ├── cryostat-2.2.0-SNAPSHOT.jar
│   │   ├── cryostat-core-2.10.0.jar
│   │   ├── dagger-2.34.1.jar
│   │   ├── encoder-1.2.2.jar
│   │   ├── flightrecorder-7.1.1.jar
│   │   ├── flightrecorder.rules-7.1.1.jar
│   │   ├── flightrecorder.rules.jdk-7.1.1.jar
│   │   ├── generex-1.0.2.jar
│   │   ├── graphql-java-17.3.jar
│   │   ├── graphql-java-extended-scalars-17.0.jar
│   │   ├── gson-2.8.9.jar
│   │   ├── httpclient-4.5.13.jar
│   │   ├── httpcore-4.4.13.jar
│   │   ├── jackson-annotations-2.11.2.jar
│   │   ├── jackson-core-2.11.2.jar
│   │   ├── jackson-databind-2.11.2.jar
│   │   ├── jackson-dataformat-yaml-2.11.2.jar
│   │   ├── jackson-datatype-jsr310-2.11.2.jar
│   │   ├── java-dataloader-3.1.0.jar
│   │   ├── javax.inject-1.jar
│   │   ├── jcip-annotations-1.0-1.jar
│   │   ├── jsoup-1.14.2.jar
│   │   ├── kubernetes-client-5.4.1.jar
│   │   ├── kubernetes-model-admissionregistration-5.4.1.jar
│   │   ├── kubernetes-model-apiextensions-5.4.1.jar
│   │   ├── kubernetes-model-apps-5.4.1.jar
│   │   ├── kubernetes-model-autoscaling-5.4.1.jar
│   │   ├── kubernetes-model-batch-5.4.1.jar
│   │   ├── kubernetes-model-certificates-5.4.1.jar
│   │   ├── kubernetes-model-common-5.4.1.jar
│   │   ├── kubernetes-model-coordination-5.4.1.jar
│   │   ├── kubernetes-model-core-5.4.1.jar
│   │   ├── kubernetes-model-discovery-5.4.1.jar
│   │   ├── kubernetes-model-events-5.4.1.jar
│   │   ├── kubernetes-model-extensions-5.4.1.jar
│   │   ├── kubernetes-model-flowcontrol-5.4.1.jar
│   │   ├── kubernetes-model-metrics-5.4.1.jar
│   │   ├── kubernetes-model-networking-5.4.1.jar
│   │   ├── kubernetes-model-node-5.4.1.jar
│   │   ├── kubernetes-model-policy-5.4.1.jar
│   │   ├── kubernetes-model-rbac-5.4.1.jar
│   │   ├── kubernetes-model-scheduling-5.4.1.jar
│   │   ├── kubernetes-model-storageclass-5.4.1.jar
│   │   ├── logging-interceptor-3.12.12.jar
│   │   ├── netty-buffer-4.1.74.Final.jar
│   │   ├── netty-codec-4.1.74.Final.jar
│   │   ├── netty-codec-dns-4.1.74.Final.jar
│   │   ├── netty-codec-http2-4.1.74.Final.jar
│   │   ├── netty-codec-http-4.1.74.Final.jar
│   │   ├── netty-codec-socks-4.1.74.Final.jar
│   │   ├── netty-common-4.1.74.Final.jar
│   │   ├── netty-handler-4.1.74.Final.jar
│   │   ├── netty-handler-proxy-4.1.74.Final.jar
│   │   ├── netty-resolver-4.1.74.Final.jar
│   │   ├── netty-resolver-dns-4.1.74.Final.jar
│   │   ├── netty-tcnative-classes-2.0.48.Final.jar
│   │   ├── netty-transport-4.1.74.Final.jar
│   │   ├── nimbus-jose-jwt-9.16.1.jar
│   │   ├── okhttp-3.12.12.jar
│   │   ├── okio-1.15.0.jar
│   │   ├── openshift-client-5.4.1.jar
│   │   ├── openshift-model-5.4.1.jar
│   │   ├── openshift-model-console-5.4.1.jar
│   │   ├── openshift-model-monitoring-5.4.1.jar
│   │   ├── openshift-model-operator-5.4.1.jar
│   │   ├── openshift-model-operatorhub-5.4.1.jar
│   │   ├── reactive-streams-1.0.3.jar
│   │   ├── slf4j-api-1.7.30.jar
│   │   ├── slf4j-jdk14-1.7.30.jar
│   │   ├── snakeyaml-1.26.jar
│   │   ├── vertx-auth-common-4.2.5.jar
│   │   ├── vertx-bridge-common-4.2.5.jar
│   │   ├── vertx-core-4.2.5.jar
│   │   ├── vertx-web-4.2.5.jar
│   │   ├── vertx-web-client-4.2.5.jar
│   │   ├── vertx-web-common-4.2.5.jar
│   │   ├── vertx-web-graphql-4.2.5.jar
│   │   └── zjsonpatch-0.3.0.jar
│   └── resources
│       └── io
│           └── cryostat
│               ├── net
│               │   └── web
│               │       ├── app.bundle.js
│               │       ├── app.css
│               │       ├── cryostat-3-icon-16px.png
│               │       ├── fonts
│               │       │   ├── overpass-bold-italic.woff
│               │       │   ├── overpass-bold-italic.woff2
│               │       │   ├── overpass-bold.woff
│               │       │   ├── overpass-bold.woff2
│               │       │   ├── overpass-extrabold-italic.woff
│               │       │   ├── overpass-extrabold-italic.woff2
│               │       │   ├── overpass-extrabold.woff
│               │       │   ├── overpass-extrabold.woff2
│               │       │   ├── overpass-extralight-italic.woff
│               │       │   ├── overpass-extralight-italic.woff2
│               │       │   ├── overpass-extralight.woff
│               │       │   ├── overpass-extralight.woff2
│               │       │   ├── overpass-heavy-italic.woff
│               │       │   ├── overpass-heavy-italic.woff2
│               │       │   ├── overpass-heavy.woff
│               │       │   ├── overpass-heavy.woff2
│               │       │   ├── overpass-italic.woff
│               │       │   ├── overpass-italic.woff2
│               │       │   ├── overpass-light-italic.woff
│               │       │   ├── overpass-light-italic.woff2
│               │       │   ├── overpass-light.woff
│               │       │   ├── overpass-light.woff2
│               │       │   ├── overpass-mono-bold.woff
│               │       │   ├── overpass-mono-bold.woff2
│               │       │   ├── overpass-mono-light.woff
│               │       │   ├── overpass-mono-light.woff2
│               │       │   ├── overpass-mono-regular.woff
│               │       │   ├── overpass-mono-regular.woff2
│               │       │   ├── overpass-mono-semibold.woff
│               │       │   ├── overpass-mono-semibold.woff2
│               │       │   ├── overpass-regular.woff
│               │       │   ├── overpass-regular.woff2
│               │       │   ├── overpass-semibold-italic.woff
│               │       │   ├── overpass-semibold-italic.woff2
│               │       │   ├── overpass-semibold.woff
│               │       │   ├── overpass-semibold.woff2
│               │       │   ├── overpass-thin-italic.woff
│               │       │   ├── overpass-thin-italic.woff2
│               │       │   ├── overpass-thin.woff
│               │       │   ├── overpass-thin.woff2
│               │       │   ├── pficon.woff
│               │       │   ├── pficon.woff2
│               │       │   ├── RedHatDisplay-Bold.woff
│               │       │   ├── RedHatDisplay-Bold.woff2
│               │       │   ├── RedHatDisplay-Medium.woff
│               │       │   ├── RedHatDisplay-Medium.woff2
│               │       │   ├── RedHatDisplay-Regular.woff
│               │       │   ├── RedHatDisplay-Regular.woff2
│               │       │   ├── RedHatText-Medium.woff
│               │       │   ├── RedHatText-Medium.woff2
│               │       │   ├── RedHatText-Regular.woff
│               │       │   └── RedHatText-Regular.woff2
│               │       ├── HTTP_API.md
│               │       ├── images
│               │       │   ├── logo-cryostat-3-horizontal.svg
│               │       │   ├── logo-cryostat-3.svg
│               │       │   ├── pfbg_2000.jpg
│               │       │   ├── pfbg_576@2x.jpg
│               │       │   ├── pfbg_576.jpg
│               │       │   ├── pfbg_768@2x.jpg
│               │       │   ├── pfbg_768.jpg
│               │       │   └── pfbg_992@2x.jpg
│               │       ├── index.html
│               │       ├── npm.attr-accept.bundle.js
│               │       ├── npm.file-selector.bundle.js
│               │       ├── npm.focus-trap.bundle.js
│               │       ├── npm.history.bundle.js
│               │       ├── npm.hoist-non-react-statics.bundle.js
│               │       ├── npm.js-base64.bundle.js
│               │       ├── npm.lodash.bundle.js
│               │       ├── npm.mini-create-react-context.bundle.js
│               │       ├── npm.nanoid.bundle.js
│               │       ├── npm.object-assign.bundle.js
│               │       ├── npm.patternfly.bundle.js
│               │       ├── npm.patternfly.css
│               │       ├── npm.prop-types.bundle.js
│               │       ├── npm.react.bundle.js
│               │       ├── npm.react-dom.bundle.js
│               │       ├── npm.react-dropzone.bundle.js
│               │       ├── npm.react-is.bundle.js
│               │       ├── npm.react-router.bundle.js
│               │       ├── npm.react-router-dom.bundle.js
│               │       ├── npm.react-router-last-location.bundle.js
│               │       ├── npm.resolve-pathname.bundle.js
│               │       ├── npm.rxjs.bundle.js
│               │       ├── npm.scheduler.bundle.js
│               │       ├── npm.tabbable.bundle.js
│               │       ├── npm.tiny-invariant.bundle.js
│               │       ├── npm.tslib.bundle.js
│               │       ├── npm.value-equal.bundle.js
│               │       └── runtime.bundle.js
│               └── version
├── cryostat.jfc
└── truststore-setup.sh

9 directories, 188 files

Looks like the truststore-setup.sh is included now and otherwise it's the same.

ebaron

Looks good, thanks!

andrewazores added dependencies Pull requests that update a dependency file build labels Jun 6, 2022

andrewazores added ci chore Refactor, rename, cleanup, etc. and removed ci labels Jun 6, 2022

andrewazores marked this pull request as ready for review June 7, 2022 19:52

andrewazores requested a review from ebaron June 7, 2022 19:52

ebaron reviewed Jun 8, 2022

View reviewed changes

andrewazores added 8 commits June 8, 2022 14:25

build(base): inline base image to mvn build

86edd5f

build(base): use podman plugin for base build

332dfa4

chore(pom): use gmaven to dynamically set base image JDK version

0195590

build base img within project and copy cryostat.jfr direct

867e4e2

drop podman-maven-plugin

d5a1e06

extract property

bca1daf

apply filtering to containerfile

9c3d24e

allows UBI image stream and tag to be defined in pom

fixup! apply filtering to containerfile

e445232

andrewazores force-pushed the inline-base branch from 6eff044 to e445232 Compare June 8, 2022 18:25

update assembly dist.xml

7e89bb5

ebaron approved these changes Jun 8, 2022

View reviewed changes

andrewazores merged commit 452fccf into main Jun 8, 2022

andrewazores deleted the inline-base branch June 8, 2022 18:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(base): inline base img into build #982

build(base): inline base img into build #982

andrewazores commented Jun 6, 2022 •

edited

Loading

github-actions bot commented Jun 6, 2022

github-actions bot commented Jun 6, 2022

github-actions bot commented Jun 6, 2022

andrewazores commented Jun 6, 2022 •

edited

Loading

andrewazores commented Jun 6, 2022

ebaron commented Jun 7, 2022

andrewazores commented Jun 7, 2022

ebaron left a comment

andrewazores commented Jun 8, 2022

ebaron commented Jun 8, 2022

andrewazores commented Jun 8, 2022

ebaron left a comment

build(base): inline base img into build #982

build(base): inline base img into build #982

Conversation

andrewazores commented Jun 6, 2022 • edited Loading

github-actions bot commented Jun 6, 2022

github-actions bot commented Jun 6, 2022

github-actions bot commented Jun 6, 2022

andrewazores commented Jun 6, 2022 • edited Loading

andrewazores commented Jun 6, 2022

ebaron commented Jun 7, 2022

andrewazores commented Jun 7, 2022

ebaron left a comment

Choose a reason for hiding this comment

andrewazores commented Jun 8, 2022

ebaron commented Jun 8, 2022

andrewazores commented Jun 8, 2022

ebaron left a comment

Choose a reason for hiding this comment

andrewazores commented Jun 6, 2022 •

edited

Loading

andrewazores commented Jun 6, 2022 •

edited

Loading