chore(controllers): rename controller files to be shared #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthvo
approved these changes
Feb 6, 2023
ebaron
added a commit
that referenced
this pull request
Feb 23, 2023
* Move controller * Move controller tests
ebaron
added a commit
that referenced
this pull request
Feb 23, 2023
* Move controller * Move controller tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main PR for #513 will add a new API and controller and much of the existing controller code will be shared between the controllers for the two APIs. This PR does the file renaming as a separate step in order to make the main PR easier to review. Otherwise, I could not get Git to treat this operation as a rename since
cryostat_controller.gowill still exist, but delegate most of its functionality toreconciler.go.This PR is targeting a feature branch. Once this PR and subsequent PR(s) have been merged into this feature branch, I will open another pull request against
main. For that final PR, I plan to not squash the commits.Related to: #513