Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(reports): remove HTML report generation #137

Merged
merged 3 commits into from
Sep 28, 2023
Merged

chore(reports): remove HTML report generation #137

merged 3 commits into from
Sep 28, 2023

Conversation

andrewazores
Copy link
Member

Depends on cryostatio/cryostat-core#261

Remove HTML generation API and do some cleanup.

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere labels Sep 22, 2023
@mergify mergify bot added the safe-to-test label Sep 22, 2023
This was referenced Sep 22, 2023
Merged
Merged
Merged
@andrewazores andrewazores marked this pull request as ready for review September 26, 2023 19:38
@andrewazores
Copy link
Member Author

cryostatio/cryostat-core#261 (comment)

@andrewazores
Copy link
Member Author

Required -core is released.

@github-actions
Copy link

This PR/issue depends on:

aali309
aali309 reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had this at first cryostat-reports: Detected Maven Version (3.8.1) is not supported, it must be in [3.8.2,).
had to update /cryostat-reports/.mvn/wrapper/maven-wrapper.properties to the suggested 3.8.2
Other than that, looks good to me.

@andrewazores
Copy link
Member Author

Ah interesting, I haven't run ./mvnw quarkus:dev in quite some time so I hadn't noticed this. I'll open a separate PR.

@andrewazores andrewazores mentioned this pull request Sep 27, 2023
Merged
@andrewazores andrewazores merged commit 173e4af into cryostatio:main Sep 28, 2023
9 checks passed
@andrewazores andrewazores deleted the report-format branch September 28, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwangggg mwangggg mwangggg left review comments

@aali309 aali309 aali309 left review comments

Assignees
No one assigned
Labels
breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewazores @aali309 @mwangggg