Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording start/stop/delete notifications should not trigger full model refresh #368

Closed
andrewazores opened this issue Feb 4, 2022 · 0 comments · Fixed by #369
Closed
Assignees
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

See also #344

In the Active Recordings Table component we listen for WebSocket notifications indicating that an active recording has been started, stopped, or deleted. If any of these occur then we trigger a full refresh of the table contents by firing a new HTTP GET request to the backend. Instead, the backend should include all relevant information about the recording that was started/stopped/deleted in the notification message, and the frontend should receive that message and use the recording information within to update the table state directly, without issuing an API request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant