Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): Add "Recording Stopped" notification on implied stop #810

Merged
merged 16 commits into from
Feb 8, 2022

Conversation

jan-law
Copy link
Contributor

@jan-law jan-law commented Feb 2, 2022

Fixes #781

@jan-law jan-law added the feat New feature or request label Feb 2, 2022
@jan-law jan-law force-pushed the stopped-notification branch from ba0a847 to afee47b Compare February 4, 2022 18:11
@jan-law
Copy link
Contributor Author

jan-law commented Feb 4, 2022

The latest CI build failure looks like #666 again:

Feb 04, 2022 6:19:57 PM io.cryostat.core.log.Logger info
INFO: io.cryostat.net.reports.SubprocessReportGenerator processing report
java.util.concurrent.ExecutionException: java.lang.NullPointerException
	at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
	at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)
	at io.cryostat.net.reports.SubprocessReportGenerator.generateReportFromFile(SubprocessReportGenerator.java:336)
	at io.cryostat.net.reports.SubprocessReportGenerator.main(SubprocessReportGenerator.java:292)
Caused by: java.lang.NullPointerException
	at org.openjdk.jmc.flightrecorder.parser.synthetic.SyntheticAttributeExtension$ModuleExportSink.addEvent(SyntheticAttributeExtension.java:206)
...
Feb 04, 2022 6:19:57 PM io.cryostat.core.log.Logger error
SEVERE: HTTP 500: Internal Server Error
io.cryostat.net.web.http.api.v2.ApiException: Internal Server Error
Caused by: java.util.concurrent.ExecutionException: io.cryostat.net.reports.SubprocessReportGenerator$SubprocessReportGenerationException: [6] An unspecified unexpected exception occurred.
	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:395)
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2022)
...
Feb 04, 2022 6:19:57 PM io.cryostat.core.log.Logger info
INFO: (10.0.2.100:53658): GET /api/beta/targets/service:jmx:rmi:%2F%2F%2Fjndi%2Frmi:%2F%2Fcryostat-itests:9091%2Fjmxrmi/reports/ReportJwtDownloadIT 500 981ms

@jan-law jan-law force-pushed the stopped-notification branch from 8d00036 to cce4bc0 Compare February 7, 2022 16:01
@andrewazores
Copy link
Member

The expected happy-path workflow seems to be working well, just those last two kinda corner cases above left. This will go nicely with cryostatio/cryostat-web#368 too - the active recordings table will update running recordings to the stopped state automatically, even without view refresh enabled.

@andrewazores andrewazores merged commit d59fbf6 into cryostatio:main Feb 8, 2022
@jan-law jan-law deleted the stopped-notification branch February 9, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Recording Stopped" notification on implied stop
2 participants