-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notifications): Add "Recording Stopped" notification on implied stop #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
reviewed
Feb 3, 2022
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
andrewazores
reviewed
Feb 3, 2022
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
andrewazores
reviewed
Feb 3, 2022
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
andrewazores
reviewed
Feb 3, 2022
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
andrewazores
reviewed
Feb 3, 2022
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
jan-law
force-pushed
the
stopped-notification
branch
from
February 4, 2022 18:11
ba0a847
to
afee47b
Compare
The latest CI build failure looks like #666 again:
|
jan-law
force-pushed
the
stopped-notification
branch
from
February 7, 2022 16:01
8d00036
to
cce4bc0
Compare
andrewazores
reviewed
Feb 7, 2022
src/main/java/io/cryostat/net/web/http/api/v1/TargetRecordingPatchStop.java
Outdated
Show resolved
Hide resolved
andrewazores
reviewed
Feb 7, 2022
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
andrewazores
reviewed
Feb 7, 2022
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
andrewazores
reviewed
Feb 7, 2022
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
The expected happy-path workflow seems to be working well, just those last two kinda corner cases above left. This will go nicely with cryostatio/cryostat-web#368 too - the active recordings table will update running recordings to the stopped state automatically, even without view refresh enabled. |
andrewazores
reviewed
Feb 7, 2022
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
andrewazores
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #781