Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMX Auth UX #116

Merged
merged 11 commits into from
Aug 19, 2020
Merged

JMX Auth UX #116

merged 11 commits into from
Aug 19, 2020

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Aug 10, 2020

Fixes #117

Based on top of #110

container-jfr-web-jmx-auth-2020-08-10_17 48 15

@andrewazores
Copy link
Member Author

andrewazores commented Aug 18, 2020

To test: use a recent (now relies on changes in cryostatio/cryostat-legacy#242) ContainerJFR backend and run it like CONTAINER_JFR_RJMX_USER=someuser CONTAINER_JFR_RJMX_PASS=somepass CONTAINER_JFR_CORS_ORIGIN=http://localhost:9000 sh run.sh. Run a local development server for this -web branch with npm run start:dev and open http://localhost:9000 in your browser. Select ContainerJFR itself as a target and go to the Recordings or Events views. A modal dialog should appear, requiring you to enter your JMX credentials before the recordings/events can be loaded.

@andrewazores andrewazores marked this pull request as ready for review August 18, 2020 18:28
@andrewazores andrewazores requested a review from ebaron August 18, 2020 18:31
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me. I'm a bit confused about how the delete button is supposed to work. Is it to delete saved credentials for the target? If so, will the user have an opportunity to do this once they've been saved?

@andrewazores
Copy link
Member Author

Yea, I think we will probably want to have some kind of UX for managing credentials, but I don't really know how to go about it. Right now the Delete button is only potentially useful if you first enter some invalid credentials and are re-prompted for credentials, and then decide you don't want the web-client to store those credentials after all. Pretty narrow and meaningless use-case currently. Once you've entered valid credentials for a target then there is no way to delete those credentials - although they only persist so long as the browser tab/window is open anyway, and are cleared as soon as you close/reopen or refresh the page.

I could just remove the Delete button for now since it doesn't really provide any meaningful functionality.

@ebaron
Copy link
Member

ebaron commented Aug 18, 2020

I'm fine with leaving it and changing it later. Up to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users should be able to provide JMX auth credentials
2 participants