Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snapshots): remove successful snapshot creation notification handling #427

Merged
merged 3 commits into from
Apr 29, 2022
Merged

fix(snapshots): remove successful snapshot creation notification handling #427

merged 3 commits into from
Apr 29, 2022

Conversation

hareetd
Copy link
Contributor

@hareetd hareetd commented Apr 28, 2022

Fixes #426

@andrewazores
Copy link
Member

Once the backend does emit a notification when a snapshot is created then the frontend will need a notification category and mapper added. Would you like to do that within this PR or create a second one for that separately?

@hareetd
Copy link
Contributor Author

hareetd commented Apr 28, 2022

I think doing it in this one would make sense, I'll create notification categories for "Snapshot Created" and "Snapshot Deleted".

@hareetd hareetd requested a review from andrewazores April 29, 2022 18:17
@andrewazores andrewazores mentioned this pull request Apr 29, 2022
Merged
@andrewazores andrewazores merged commit d4e9276 into cryostatio:main Apr 29, 2022
@hareetd hareetd deleted the fix-snapshot-creation-notifications branch April 29, 2022 22:25
@ebaron ebaron added the fix label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snapshot creation notification handling should be delegated to the backend
3 participants
@hareetd @andrewazores @ebaron