Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): embed web-client with fake API stubs as a demo #109

Merged
merged 40 commits into from
May 9, 2023

Conversation

andrewazores
Copy link
Member

No description provided.

@andrewazores andrewazores changed the base branch from main to version-230 May 2, 2023 15:23
@andrewazores andrewazores added the feat New feature or request label May 2, 2023
@andrewazores andrewazores force-pushed the demo-embedded branch 5 times, most recently from dbbfb4e to 2451f4a Compare May 2, 2023 16:41
@andrewazores andrewazores force-pushed the demo-embedded branch 2 times, most recently from b69ceeb to 4890605 Compare May 5, 2023 17:49
@andrewazores andrewazores marked this pull request as ready for review May 5, 2023 17:51
@andrewazores andrewazores requested review from tthvo and maxcao13 May 5, 2023 17:52
@tthvo
Copy link
Member

tthvo commented May 5, 2023

Is it just me or how do we get pass the login page?

Screenshot from 2023-05-05 16-02-08

@andrewazores
Copy link
Member Author

Hmm. How did you launch the preview server and which browser are you using? I do:

$ bundle exec jekyll serve --watch --livereload --open-url --future --config _config.yml,_config-dev.yml

and it seems to be working for me with Firefox and (Ungoogled) Chromium.

@tthvo
Copy link
Member

tthvo commented May 5, 2023

Oh i see now. I was trying to build a new asset and then launch the server (with Firefox), which somewhat does not snub out auth.

@andrewazores
Copy link
Member Author

The stubs are all done in-memory in your browser, ie the embedded demo's network requests all get intercepted and handled client-side, so I'm not sure what the problem was... what commands did you run to build and launch?

@tthvo
Copy link
Member

tthvo commented May 5, 2023

I tried following the README to build the new asset.

$ bash build-demo.bash cryostat-v2.3
$ bundle exec jekyll serve --watch --livereload --open-url --future --config _config.yml,_config-dev.yml

@andrewazores
Copy link
Member Author

Ahh I see what you mean. Okay, yea, that's the same thing I do... huh.

@tthvo
Copy link
Member

tthvo commented May 5, 2023

Wait I think there was a step that I skip.

+ patch -p0
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/assets/demo/site/index.html b/assets/demo/site/index.html
|index 186d189..93f885d 100644
|--- a/assets/demo/site/index.html
|+++ b/assets/demo/site/index.html
--------------------------
File to patch: 

This probably leaves out the snub js. Is there a version of patch I need to use? I just run dnf install patch to get the tool.

demo/package-lock.json Outdated Show resolved Hide resolved
demo/index.html.patch Outdated Show resolved Hide resolved
@andrewazores
Copy link
Member Author

This probably leaves out the snub js. Is there a version of patch I need to use? I just run dnf install patch to get the tool.

Ah yes, that would do it. dnf install patch should get the right one and the output you have looks right. Let me see how I broke the patch file.

Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Would it make sense to fake add/edit/remove metadata labels as well?

.gitignore Outdated Show resolved Hide resolved
demo/fake-api.js Outdated Show resolved Hide resolved
@andrewazores andrewazores merged commit ccf9633 into cryostatio:version-230 May 9, 2023
@andrewazores andrewazores deleted the demo-embedded branch May 9, 2023 22:42
andrewazores added a commit to andrewazores/cryostatio.github.io that referenced this pull request May 24, 2023
andrewazores added a commit that referenced this pull request May 25, 2023
….0 version (#103)

* feat(version): copy guides to 2.2.0 version and create new latest/2.3.0 version

* docs(agent): create initial content for Cryostat Agent (#101)

* Create document-agent's-general-description+purpose.md

Documented the Agent's general description + purpose

Signed-off-by: Esther Christopher <estheradamuchris@gmail.com>

* Update document-agent's-general-description+purpose.md

Effected the corrections. 

Signed-off-by: Esther Christopher <estheradamuchris@gmail.com>

* minor fixes

* move content into guide

---------

Signed-off-by: Esther Christopher <estheradamuchris@gmail.com>
Co-authored-by: Andrew Azores <aazores@redhat.com>

* docs(screenshots): update screenshots for 2.3.0 (#105)

* update screenshots, fix some anchors

* correct filenames

* remove unnecessary paragraph tags

* pluralize

* clarify

* simplify

* singularize

* fixup! singularize

* fixup! fixup! singularize

* chore(versions): bump supported platform versions (#111)

* feat(demo): embed web-client with fake API stubs as a demo (#109)

* docs(getting-started): update sample app example (#115)

* docs(auth): remove outdated Bearer form, add details on OpenShift and Basic mechanisms (#113)

* doc(auth): remove outdated Bearer form, add details on OpenShift and Basic mechanisms

Signed-off-by: Andrew Azores <aazores@redhat.com>

* reflow

* formatting

* backtick quotes

---------

Signed-off-by: Andrew Azores <aazores@redhat.com>

* feat(cred): document credentials testing table (#119)

* docs(get-started): add information about the Agent and JMX config (#104)

* docs(get-started): add information about the Agent and JMX config

* typo

* rephrase

* quotes and typo

* add anchors

* openshift -> kubernetes

* add note about maven registry auth

* add comments

* accept suggestion

* typo

* formatting

* typo

* formatting

* break comment lines

* use yaml multiline

* plural

* rephrase

* add explanation comment

* fixup! add explanation comment

* rebase fix

* list configuration combinations before explaining them

* add links

* rephrase

* fix typo

* fixup! fix typo

* explain agent deployment environment variables more

* explain cross-namespace Agent and Cryostat

* reference agent version 0.2.1

* in hybrid agent setup, skip the jfr-jmx named port

* set explicit hostname for JMX

* reorganize

* feat(topology): document topology view and custom target form (#118)

* chore(rules): update docs to mention Match Expression Visualizer

* feat(topology): add docs for creating a custom target

* feat(topology): document topology usage

Signed-off-by: Thuan Vo <thvo@redhat.com>

---------

Signed-off-by: Thuan Vo <thvo@redhat.com>

* chore(docs): update (un)installation info, images, and document ClusterCryostat (#117)

* docs(install): update installation information and images

* update operator-sdk version

* add table of contents

* update step reference and links

* add documentation about ClusterCryostat

* split text into list

* use usual default CR YAML for example

* specify example's installation mode

* distinguish OpenShift Console Topology View

* cleanup outdated info

* fixup! cleanup outdated info

* correct screenshot

* explain why CRs are namespace-specific

* commas

* remove outdated alternate operator installation methods

* remove unused uninstallation steps

* inline doc

* point GitHub docs links to release branches, not latest development

* add detail

* comma

* clarify one instance of Kubernetes-specific requirement

* update olm instructions

* syntax highlighting hints

* docs(dashboard): document dashboard and dashboard cards (#121)

* init commit

Signed-off-by: Max Cao <macao@redhat.com>

* add mbean metrics, layouts/templates

Signed-off-by: Max Cao <macao@redhat.com>

* fix widescreen -> fullscreen

Signed-off-by: Max Cao <macao@redhat.com>

---------

Signed-off-by: Max Cao <macao@redhat.com>

* feat(blog): add 2.3.0 release post (#124)

* chore(gem): add table-of-contents plugin

* chore(blog): enable toc plugin on existing blog posts

* feat(blog): add 2.3.0 release announcement post

* link helm to specific release

* add note about OLM

* add link

* comma

* comma

* set blog date

---------

Signed-off-by: Esther Christopher <estheradamuchris@gmail.com>
Signed-off-by: Andrew Azores <aazores@redhat.com>
Signed-off-by: Thuan Vo <thvo@redhat.com>
Signed-off-by: Max Cao <macao@redhat.com>
Co-authored-by: Esther Christopher <estheradamuchris@gmail.com>
Co-authored-by: Thuan Vo <thvo@redhat.com>
Co-authored-by: Max Cao <macao@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants