feat(agent): describe usage of Agent init container for multi-stage container build #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmah88
reviewed
Oct 4, 2024
get-started/index.md
Outdated
| ```Dockerfile | ||
| ARG cryostat_agent_version | ||
|
|
||
| FROM quay.io/cryostat/cryostat-agent-init:${agent_version} AS cryostat_agent |
There was a problem hiding this comment.
should this be cryostat_agent_version?
cmah88
reviewed
Oct 4, 2024
| ``` | ||
|
|
||
| Next we must rebuild our container image. This is specific to your application but will likely look something like | ||
| `docker build -t docker.io/myorg/myapp:latest -f src/main/docker/Dockerfile --build-arg cryostat_agent_version={{ site.data.versions.agent.version }} .` |
There was a problem hiding this comment.
i dont see 0.4.0 in the quay repo
There was a problem hiding this comment.
There isn't one, that's a new build/publication feature that was introduced more recently.
|
@cryostatio/reviewers ping |
andrewazores
force-pushed
the
agent-multistage
branch
from
60de4db to
f6eaff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #202
Related to #90