-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): update query processing to support new grafana dashboard #135
Conversation
78211cd
to
473a12d
Compare
src/main/java/io/cryostat/jfr/datasource/server/Datasource.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if it's possible to set the time range automatically when "setting" the file?
Related to cryostatio/cryostat-grafana-dashboard#13. Unfortunately, I am not sure they implemented the feature yet :\ |
No support for |
Fixes #128
Fixes #129
Fixes #130
Fixes #134
Fixes #78
Fixes #62
Related to cryostatio/cryostat-grafana-dashboard#12
What's new?
Queries now support url-parameter-styled target (Only timeseries). This is primarily used to categorize plots based on a field of the same event. For example:
Use case: individual plots on
jdk.ObjectAllocationSample.weight
for each class type using variables & single panel with all plots identified by legends./search
endpoint was corrected to acceptPOST
with search target in request body.SimpleJson
plugin was not clear about this, but another similar alternative explains well: https://grafana.com/grafana/plugins/simpod-json-datasource/. For example:$ curl -X POST --data '{ "target": "jdk.ObjectAllocationSample.classObject" }' localhost:8080/search
Use case: used to defined a variable that can be reference in queries. See posts on grafana variables: https://grafana.com/docs/grafana/latest/dashboards/variables/
A well-known unit is defined for returned data:
memory
: BYTEtimespan
: MILISECONDfrequency
: HzNon-numeric fields are also returned as data points if specified. Some fields are not string (i.e. JSON) so it is on the "query-er" to do transformation/override.
Recording metadata (i.e. recordingDuration and startTime) does not depends on
jdk.ActiveRecording
event. See Andrew's comment. This helps panel of these information persist across time frame changes and avoid overlapping of other recordings.Test resources (i.e. test recording) are updated to support new event
jdk.ObjectAllocationSample
.See corresponding Grafana updates: cryostatio/cryostat-grafana-dashboard#12