Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite default relayer config with configs used to setup chains #28

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

macong-cdc
Copy link
Contributor

No description provided.

global:
timeout: 10s
light-cache-size: 20
paths:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paths seem not used anywhere, I guess it's not needed for hermes? Have you tested it already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have tested, paths is not used and needed for hermes.
Only configurations here are used by Hermes.

@yihuang yihuang self-requested a review September 8, 2021 09:51
Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yihuang
Copy link
Collaborator

yihuang commented Sep 8, 2021

Could you also add a changelog?

@yihuang
Copy link
Collaborator

yihuang commented Sep 8, 2021

It seems your first commit is not signed?

@macong-cdc
Copy link
Contributor Author

It seems your first commit is not signed?

Sorry, just signed it

@yihuang yihuang merged commit f4ecb7f into crypto-com:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants