Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem:(CRO-490) tiny_hderive uses the same secp256k1 library and it's outdated #475

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Problem:(CRO-490) tiny_hderive uses the same secp256k1 library and it's outdated #475

merged 1 commit into from
Oct 16, 2019

Conversation

leejw51
Copy link
Contributor

@leejw51 leejw51 commented Oct 15, 2019

Solution: remove dependency of tiny_hderive, replace with secp256k1 directly, which is already being used in core
add module

compile ok

hdwallet working

fix hdwallet

display info

tidy up

add zeroize

@codecov
Copy link

codecov bot commented Oct 15, 2019 •
edited
Loading

Codecov Report

Merging #475 into master will increase coverage by 0.61%.
The diff coverage is 83.63%.

@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
+ Coverage   65.24%   65.86%   +0.61%     
==========================================
  Files         112      117       +5     
  Lines       13009    13450     +441     
==========================================
+ Hits         8488     8859     +371     
- Misses       4521     4591      +70
Impacted Files Coverage Δ
client-core/src/lib.rs 100% <ø> (ø) ⬆️
client-core/src/hdwallet/error.rs 0% <0%> (ø)
client-core/src/hdwallet/extended_key/key_index.rs 70.96% <70.96%> (ø)
client-core/src/hdwallet/key_chain/chain_path.rs 72.85% <72.85%> (ø)
client-core/src/hdwallet/key_chain.rs 86.45% <86.45%> (ø)
client-core/src/service/key_service.rs 90.68% <89.47%> (+1.21%) ⬆️
client-core/src/hdwallet/extended_key.rs 91.97% <91.97%> (ø)
... and 3 more

@tomtau tomtau requested review from leejw51crypto, devashishdxt, tomtau and calvinaco and removed request for leejw51crypto October 16, 2019 00:57
tomtau
tomtau suggested changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the some of the code was adapted from other project, the corresponding files should have attribution headers + the project should be mentioned in https://github.com/crypto-com/chain/blob/master/NOTICE

client-core/src/hdwallet/extended_key.rs Outdated Show resolved Hide resolved
client-core/src/hdwallet/error.rs Show resolved Hide resolved
client-core/src/hdwallet/extended_key/key_index.rs Show resolved Hide resolved
client-core/src/hdwallet/key_chain.rs Show resolved Hide resolved
client-core/src/hdwallet/key_chain/chain_path.rs Show resolved Hide resolved
client-core/src/hdwallet/mod.rs Outdated Show resolved Hide resolved
client-core/src/hdwallet/mod.rs Outdated Show resolved Hide resolved
client-core/src/lib.rs Show resolved Hide resolved
client-core/src/hdwallet/traits.rs Show resolved Hide resolved
@tomtau
Copy link
Contributor

tomtau commented Oct 16, 2019

And perhaps re-generate Cargo.lock?

@leejw51crypto leejw51crypto force-pushed the cro-490 branch 2 times, most recently from cb470f7 to 3e71a60 Compare October 16, 2019 03:23
tomtau
tomtau suggested changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small fixes, otherwise ok -- @leejw51 @leejw51crypto after the fixes, could you squash the commits?

NOTICE Show resolved Hide resolved
NOTICE Outdated Show resolved Hide resolved
@leejw51crypto leejw51crypto force-pushed the cro-490 branch 2 times, most recently from eb9aff1 to 9907d97 Compare October 16, 2019 06:29
@leejw51crypto
Copy link
Collaborator

because it is bip44 standard, output is exactly the same with tiny-hderive

@leejw51crypto
Problem:(CRO-490) tiny_hderive uses the same secp256k1 library and it…
fea6e1e 
…'s outdated

Solution: remove dependency of tiny_hderive, replace with secp256k1 directly, which is already being used in core
add module


compile ok


hdwallet working


fix hdwallet


display info


tidy up


add zeroize


add copyright


Update client-core/src/hdwallet/extended_key.rs

thanks

Co-Authored-By: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
add attribution header


remove unnecessary code


Update client-core/src/hdwallet/mod.rs

thanks

Co-Authored-By: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
remove .git


add staking address unit-test
tomtau
tomtau approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Oct 16, 2019
@bors @leejw51crypto
Merge #475
7d24388 
475: Problem:(CRO-490) tiny_hderive uses the same secp256k1 library and it's outdated r=tomtau a=leejw51

Solution: remove dependency of tiny_hderive, replace with secp256k1 directly, which is already being used in core
add module


compile ok


hdwallet working


fix hdwallet


display info


tidy up


add zeroize



Co-authored-by: Jongwhan Lee <jonghwan@crypto.com>
@bors
Copy link
Contributor

bors bot commented Oct 16, 2019

Build succeeded

@bors bors bot merged commit fea6e1e into crypto-com:master Oct 16, 2019
bors bot added a commit that referenced this pull request Mar 23, 2020
@bors @dependabot-preview
Merge #1276
500fde7 
1276: Bump cbindgen from 0.13.1 to 0.13.2 r=tomtau a=dependabot-preview[bot]

Bumps [cbindgen](https://github.com/eqrion/cbindgen) from 0.13.1 to 0.13.2.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/eqrion/cbindgen/blob/master/CHANGES">cbindgen's changelog</a>.</em></p>
<blockquote>
<h2>0.13.2</h2>
<pre><code> * Constants now have suitable documentation. ([#471](mozilla/cbindgen#471))
 * Fixed some C warnings by emitting void when there are no arguments. ([#470](mozilla/cbindgen#470))
 * Avoids reading cargo.toml when not needed, which can cause panics in workspace situations.
 * Only write `default` cases if the switch is not exhaustive. ([#475](mozilla/cbindgen#475))
 * Some warnings have been refined. ([#477](mozilla/cbindgen#477))
 * Code generation for static arrays has been fixed. ([#479](mozilla/cbindgen#479))
 * Opt-in support for constexpr in constants. ([#481](mozilla/cbindgen#481))
 * Fix C code generation and some warnings when extremely large constants are used. ([#490](mozilla/cbindgen#490))
 * Proper escaping of enum variants and fields. ([#483](mozilla/cbindgen#483))
 * Added support for RefCell (as an opaque type) and Cell. ([#489](mozilla/cbindgen#489))
</code></pre>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/eqrion/cbindgen/commit/17d7aad7d07dce8aa665aedbc75c39953afe1600"><code>17d7aad</code></a> Release v0.13.2</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/fc577f2a28898b5345ed431fb172c4ede84fa2bf"><code>fc577f2</code></a> support large integer constants (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/490">#490</a>)</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/6218281443ff9bb21c9502369497f7a7c24dd078"><code>6218281</code></a> updated constant_big test case with large negative numbers</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/8638652d1d72296888b540f1ae4a194991eba08b"><code>8638652</code></a> ran rustfmt</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/7101465403dec23f8752d4b6359e998e89ca3b6b"><code>7101465</code></a> avoid gcc warning by appending ULL suffix to integer literals that are too bi...</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/5a4d74b9118928946dd10a49c4891a2610c55437"><code>5a4d74b</code></a> ir: escape export_name while writing source of EnumVariant</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/e2b2c81221581f21e40d98045323c5d0b7844e0c"><code>e2b2c81</code></a> ir: escape tagged union's field name</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/c3442809b9e0be814918de6281469a955acfe7df"><code>c344280</code></a> tests: Add tests for cell and refcell.</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/249b41ce8a57db2c46fdd74b65f045cfc46ed4c0"><code>249b41c</code></a> ir: Add support for RefCell and Cell.</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/6654f99251769e9e037824d471f9f39e8d536b90"><code>6654f99</code></a> main: Provide a somewhat-useful error message for --verify changes.</li>
<li>Additional commits viewable in <a href="https://github.com/eqrion/cbindgen/compare/v0.13.1...v0.13.2">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=cbindgen&package-manager=cargo&previous-version=0.13.1&new-version=0.13.2)](https://dependabot.com/compatibility-score/?dependency-name=cbindgen&package-manager=cargo&previous-version=0.13.1&new-version=0.13.2)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)



</details>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leejw51crypto leejw51crypto leejw51crypto left review comments

@devashishdxt devashishdxt devashishdxt left review comments

@tomtau tomtau tomtau approved these changes

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leejw51 @tomtau @leejw51crypto @devashishdxt