This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: deprecated enclave launch token functionality (CRO-499) #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtau
requested review from
calvinaco,
devashishdxt,
leejw51crypto and
lezzokafka
devashishdxt
approved these changes
Oct 21, 2019
leejw51crypto
approved these changes
Oct 21, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 21, 2019
494: Problem: deprecated enclave launch token functionality (CRO-499) r=tomtau a=tomtau Solution: removed the enclave protocol parts related to them; updated the enclave launcher to use dummy values in the meantime -- NOTE: Rust SDK isn't updated yet, hence the need of dummy values for the moment (launch_token and launch_token_updated are now deprecated according to https://download.01.org/intel-sgx/linux-2.6/docs/Intel_SGX_Developer_Reference_Linux_2.6_Open_Source.pdf. They are fully ignored by psw/sgx_urts.) Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
Build failed |
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
==========================================
+ Coverage 65.66% 65.71% +0.05%
==========================================
Files 117 117
Lines 13611 13602 -9
==========================================
+ Hits 8937 8938 +1
+ Misses 4674 4664 -10
|
Solution: removed the enclave protocol parts related to them; updated the enclave launcher to use dummy values in the meantime -- NOTE: Rust SDK isn't updated yet, hence the need of dummy values for the moment (launch_token and launch_token_updated are now deprecated according to https://download.01.org/intel-sgx/linux-2.6/docs/Intel_SGX_Developer_Reference_Linux_2.6_Open_Source.pdf. They are fully ignored by psw/sgx_urts.)
tomtau
force-pushed
the
fix/remove-stored-launch
branch
from
b338342 to
69edfd0
Compare
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Oct 21, 2019
494: Problem: deprecated enclave launch token functionality (CRO-499) r=tomtau a=tomtau Solution: removed the enclave protocol parts related to them; updated the enclave launcher to use dummy values in the meantime -- NOTE: Rust SDK isn't updated yet, hence the need of dummy values for the moment (launch_token and launch_token_updated are now deprecated according to https://download.01.org/intel-sgx/linux-2.6/docs/Intel_SGX_Developer_Reference_Linux_2.6_Open_Source.pdf. They are fully ignored by psw/sgx_urts.) Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Apr 6, 2020
1387: Bump cbindgen from 0.13.2 to 0.14.0 r=tomtau a=dependabot-preview[bot] Bumps [cbindgen](https://github.com/eqrion/cbindgen) from 0.13.2 to 0.14.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/eqrion/cbindgen/blob/master/CHANGES">cbindgen's changelog</a>.</em></p> <blockquote> <h2>0.14.0</h2> <pre><code> * Minor tweak at how [export.exclude] is handled to allow excluding generic instantiations in C mode. ([#501](mozilla/cbindgen#501)) * Documented cpp_compat option. ([#496](mozilla/cbindgen#496)) * Fixed a panic when parsing associated constants for a built-in type. ([#494](mozilla/cbindgen#494)) </code></pre> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/eqrion/cbindgen/commit/4a38a48937264d6ec162b2fd47ffd0e7a091ca72"><code>4a38a48</code></a> Release 0.14.0</li> <li><a href="https://github.com/eqrion/cbindgen/commit/39bae60ad7ac4711d8fccc0d098ecef98b37d559"><code>39bae60</code></a> Generate test object files in a temporary directory instead of in-tree</li> <li><a href="https://github.com/eqrion/cbindgen/commit/ec1631f3e47686e6e0c1b7641bb08b0e39c59250"><code>ec1631f</code></a> Allow excluding monomorph structs in C mode.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/6fd245096dcd5c50c1065b4bd6ce62a09df0b39b"><code>6fd2450</code></a> Add missing cpp_compat documentation.</li> <li><a href="https://github.com/eqrion/cbindgen/commit/c265a7562a5ee815057efcc8b1aca31cd3d5318d"><code>c265a75</code></a> parser: Don't panic when finding associated constants to a primitive.</li> <li>See full diff in <a href="https://github.com/eqrion/cbindgen/compare/v0.13.2...v0.14.0">compare view</a></li> </ul> </details> <br /> [](https://dependabot.com/compatibility-score/?dependency-name=cbindgen&package-manager=cargo&previous-version=0.13.2&new-version=0.14.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> 1388: Bump serde_json from 1.0.50 to 1.0.51 r=tomtau a=dependabot-preview[bot] Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.50 to 1.0.51. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p> <blockquote> <h2>v1.0.51</h2> <ul> <li>Terminate StreamDeserializer after errors instead of repeatedly reparsing the same failed input (<a href="https://github-redirect.dependabot.com/serde-rs/json/issues/647">#647</a>)</li> <li>Add FusedIterator impls for StreamDeserializer and for Map's various iterators</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/json/commit/f77c84dd3df7fe4db8932d62d8b3b7c440417dda"><code>f77c84d</code></a> Release 1.0.51</li> <li><a href="https://github.com/serde-rs/json/commit/8e76584c20cd56516e340e56b133bcef50f7ebc0"><code>8e76584</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/serde-rs/json/issues/649">#649</a> from serde-rs/fused</li> <li><a href="https://github.com/serde-rs/json/commit/d13374812226f20c9d194bcf5aa1bcb36f759bd6"><code>d133748</code></a> Implement FusedIterator for StreamDeserializer where possible</li> <li><a href="https://github.com/serde-rs/json/commit/858b01d85219c6e8c25efefd3b6bb2aba87a9615"><code>858b01d</code></a> Implement FusedIterator for Map iterators</li> <li><a href="https://github.com/serde-rs/json/commit/4c81923102dccbf62a735499bbb9494b05dd7b79"><code>4c81923</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/serde-rs/json/issues/648">#648</a> from serde-rs/streamerror</li> <li><a href="https://github.com/serde-rs/json/commit/e99e9d3713b453b6ffb2adc22f35d6276c6fa08d"><code>e99e9d3</code></a> Return None after stream deserializer has failed</li> <li><a href="https://github.com/serde-rs/json/commit/a1b1199e729d95453560a999f6de7be00783d6ae"><code>a1b1199</code></a> Test stream behavior after error</li> <li>See full diff in <a href="https://github.com/serde-rs/json/compare/v1.0.50...v1.0.51">compare view</a></li> </ul> </details> <br /> [](https://dependabot.com/compatibility-score/?dependency-name=serde_json&package-manager=cargo&previous-version=1.0.50&new-version=1.0.51) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: removed the enclave protocol parts related to them;
updated the enclave launcher to use dummy values in the meantime
--
NOTE: Rust SDK isn't updated yet, hence the need of dummy values for the moment
(launch_token and launch_token_updated are now deprecated according to https://download.01.org/intel-sgx/linux-2.6/docs/Intel_SGX_Developer_Reference_Linux_2.6_Open_Source.pdf. They are fully ignored by psw/sgx_urts.)