Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem: (CRO-498) No events for punishments (jailing/slashing) #504

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Problem: (CRO-498) No events for punishments (jailing/slashing) #504

merged 1 commit into from
Oct 22, 2019

Conversation

devashishdxt
Copy link
Collaborator

Solution: Create tendermint events for punishments

tomtau
tomtau suggested changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for filtering, it may be better not to emit any event if there are no accounts to punish instead of emitting events with empty internal attributes

@devashishdxt
Problem: (CRO-498) No events for punishments (jailing/slashing)
80827fd 
Solution: Create tendermint events for punishments
@devashishdxt devashishdxt requested a review from tomtau October 22, 2019 09:35
@codecov
Copy link

codecov bot commented Oct 22, 2019 •
edited
Loading

Codecov Report

Merging #504 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   67.03%   67.08%   +0.04%     
==========================================
  Files         120      120              
  Lines       14031    14051      +20     
==========================================
+ Hits         9406     9426      +20     
  Misses       4625     4625
Impacted Files Coverage Δ
chain-abci/src/app/slash_accounts.rs 97.29% <100%> (+0.52%) ⬆️
chain-core/src/common/mod.rs 93.33% <100%> (+1.02%) ⬆️
chain-abci/src/app/mod.rs 83.46% <100%> (+0.84%) ⬆️

tomtau
tomtau approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Oct 22, 2019
@bors @devashishdxt
Merge #504
cce38ba 
504: Problem: (CRO-498) No events for punishments (jailing/slashing) r=tomtau a=devashishdxt

Solution: Create tendermint events for punishments

Co-authored-by: Devashish Dixit <devashish@crypto.com>
@bors
Copy link
Contributor

bors bot commented Oct 22, 2019

Build succeeded

@bors bors bot merged commit 80827fd into crypto-com:master Oct 22, 2019
@devashishdxt devashishdxt deleted the punishment-events branch October 23, 2019 02:18
leejw51crypto pushed a commit to leejw51crypto/chain that referenced this pull request Oct 23, 2019
@bors @dependabot-preview
Merge crypto-com#490
00ed20c 
490: Bump jsonrpc-derive from 14.0.0 to 14.0.1 r=tomtau a=dependabot-preview[bot]

Bumps [jsonrpc-derive](https://github.com/paritytech/jsonrpc) from 14.0.0 to 14.0.1.
<details>
<summary>Commits</summary>

- [`b4635c5`](paritytech/jsonrpc@b4635c5) Bump version. ([crypto-com#509](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/509))
- [`3fc22d1`](paritytech/jsonrpc@3fc22d1) Update syn & co ([crypto-com#507](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/507))
- [`d1993a8`](paritytech/jsonrpc@d1993a8) Fix race condition on `wait()` ([crypto-com#504](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/504))
- [`8ebb62d`](paritytech/jsonrpc@8ebb62d) Disable travis & appveyor. ([crypto-com#506](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/506))
- [`1f11075`](paritytech/jsonrpc@1f11075) Integrate gitlab ci ([crypto-com#503](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/503))
- [`d3d8c6b`](paritytech/jsonrpc@d3d8c6b) ignore dropped connections ([crypto-com#502](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/502))
- [`4418476`](paritytech/jsonrpc@4418476) Make sure RpcEventLoop is Send+Sync ([crypto-com#499](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/499))
- [`cc8f26d`](paritytech/jsonrpc@cc8f26d) Solve compiler error when serde is not a dependency of user project ([crypto-com#481](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/481)) (#...
- See full diff in [compare view](paritytech/jsonrpc@v14.0.0...v14.0.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=jsonrpc-derive&package-manager=cargo&previous-version=14.0.0&new-version=14.0.1)](https://dependabot.com/compatibility-score.html?dependency-name=jsonrpc-derive&package-manager=cargo&previous-version=14.0.0&new-version=14.0.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)



</details>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
leejw51crypto pushed a commit to leejw51crypto/chain that referenced this pull request Oct 23, 2019
@bors @dependabot-preview
Merge crypto-com#491
3a2dd62 
491: Bump jsonrpc-core-client from 14.0.0 to 14.0.1 r=tomtau a=dependabot-preview[bot]

Bumps [jsonrpc-core-client](https://github.com/paritytech/jsonrpc) from 14.0.0 to 14.0.1.
<details>
<summary>Commits</summary>

- [`b4635c5`](paritytech/jsonrpc@b4635c5) Bump version. ([crypto-com#509](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/509))
- [`3fc22d1`](paritytech/jsonrpc@3fc22d1) Update syn & co ([crypto-com#507](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/507))
- [`d1993a8`](paritytech/jsonrpc@d1993a8) Fix race condition on `wait()` ([crypto-com#504](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/504))
- [`8ebb62d`](paritytech/jsonrpc@8ebb62d) Disable travis & appveyor. ([crypto-com#506](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/506))
- [`1f11075`](paritytech/jsonrpc@1f11075) Integrate gitlab ci ([crypto-com#503](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/503))
- [`d3d8c6b`](paritytech/jsonrpc@d3d8c6b) ignore dropped connections ([crypto-com#502](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/502))
- [`4418476`](paritytech/jsonrpc@4418476) Make sure RpcEventLoop is Send+Sync ([crypto-com#499](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/499))
- [`cc8f26d`](paritytech/jsonrpc@cc8f26d) Solve compiler error when serde is not a dependency of user project ([crypto-com#481](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/481)) (#...
- See full diff in [compare view](paritytech/jsonrpc@v14.0.0...v14.0.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=jsonrpc-core-client&package-manager=cargo&previous-version=14.0.0&new-version=14.0.1)](https://dependabot.com/compatibility-score.html?dependency-name=jsonrpc-core-client&package-manager=cargo&previous-version=14.0.0&new-version=14.0.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)



</details>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomtau tomtau tomtau approved these changes

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner

@leejw51crypto leejw51crypto Awaiting requested review from leejw51crypto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devashishdxt @tomtau