Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: denom conversion in cosmos-sdk is not used #269

Closed
yihuang opened this issue Nov 17, 2020 · 1 comment
Closed

Problem: denom conversion in cosmos-sdk is not used #269

yihuang opened this issue Nov 17, 2020 · 1 comment
Assignees
@yihuang

Comments

@yihuang
Copy link
Collaborator

yihuang commented Nov 17, 2020

cosmos/cosmos-sdk#7777

denom conversion and decimal support is merged in cosmos-sdk now, we can cleanup our forked cli command code now.
@leejw51crypto
Copy link
Contributor

yes, i think so,
it will simplify our code-base

@yihuang yihuang self-assigned this Nov 17, 2020
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 17, 2020
@yihuang
Problem (fix crypto-org-chain#269): denom conversion in cosmos-sdk is…
8a0ade5 
… not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 17, 2020
@yihuang
Problem (fix crypto-org-chain#269): denom conversion in cosmos-sdk is…
8306f90 
… not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 17, 2020
@yihuang
Problem (fix crypto-org-chain#269): denom conversion in cosmos-sdk is…
738bef8 
… not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 17, 2020
@yihuang
Problem (fix crypto-org-chain#269): denom conversion in cosmos-sdk is…
032f0d2 
… not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 17, 2020
@yihuang
Problem (fix crypto-org-chain#269): denom conversion in cosmos-sdk is…
d291856 
… not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 17, 2020
@yihuang
Problem (fix crypto-org-chain#269): denom conversion in cosmos-sdk is…
56fc904 
… not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 17, 2020
@yihuang
Problem (fix crypto-org-chain#269): denom conversion in cosmos-sdk is…
73e3a38 
… not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 17, 2020
@yihuang
Problem (fix crypto-org-chain#269): denom conversion in cosmos-sdk is…
ebf3b56 
… not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 17, 2020
@yihuang
Problem (fix crypto-org-chain#269 crypto-org-chain#200): denom conver…
4e0e88d 
…sion in cosmos-sdk is not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 19, 2020
@yihuang
Problem (fix crypto-org-chain#269 crypto-org-chain#200): denom conver…
40c2326 
…sion in cosmos-sdk is not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 19, 2020
@yihuang
Problem (fix crypto-org-chain#269 crypto-org-chain#200): denom conver…
1c8c5d3 
…sion in cosmos-sdk is not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 25, 2020
@yihuang
Problem (fix crypto-org-chain#269 crypto-org-chain#200): denom conver…
194308d 
…sion in cosmos-sdk is not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 25, 2020
@yihuang
Problem (fix crypto-org-chain#269 crypto-org-chain#200): denom conver…
93e55d5 
…sion in cosmos-sdk is not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 25, 2020
@yihuang
Problem (fix crypto-org-chain#269 crypto-org-chain#200): denom conver…
590696d 
…sion in cosmos-sdk is not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 25, 2020
@yihuang
Problem (fix crypto-org-chain#269 crypto-org-chain#200): denom conver…
71372a3 
…sion in cosmos-sdk is not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 26, 2020
@yihuang
Problem (fix crypto-org-chain#269 crypto-org-chain#200): denom conver…
73405c7 
…sion in cosmos-sdk is not used

Solution:
- update to cosmos-sdk master
- use sdk.ParseCoinsNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 27, 2020
@yihuang
Problem (fix crypto-org-chain#269 crypto-org-chain#200): denom conver…
ec73b86 
…sion in cosmos-sdk is not used

Solution:
- cherry-pick denom-conv feature to cosmos-sdk rc3
- use sdk.ParseCoinsNormalized and sdk.ParseCoinNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 27, 2020
@yihuang
Problem (fix crypto-org-chain#269 crypto-org-chain#200): denom conver…
32f5b1c 
…sion in cosmos-sdk is not used

Solution:
- cherry-pick denom-conv feature to cosmos-sdk rc3
- use sdk.ParseCoinsNormalized and sdk.ParseCoinNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
yihuang added a commit to yihuang/chain-main that referenced this issue Nov 27, 2020
@yihuang
Problem (fix crypto-org-chain#269 crypto-org-chain#200): denom conver…
e648358 
…sion in cosmos-sdk is not used

Solution:
- cherry-pick denom-conv feature to cosmos-sdk rc3
- use sdk.ParseCoinsNormalized and sdk.ParseCoinNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
tomtau pushed a commit to tomtau/chain-main that referenced this issue Dec 15, 2020
@yihuang @tomtau
Problem (fix crypto-org-chain#269 crypto-org-chain#200): denom conver…
243c9cf 
…sion in cosmos-sdk is not used

Solution:
- cherry-pick denom-conv feature to cosmos-sdk rc3
- use sdk.ParseCoinsNormalized and sdk.ParseCoinNormalized
- cleanup unused code
- re-organize code to minimize diff between app/app.go and
  simapp/app.go, cmd/chain-maind/app/app.go and simapp/simd/cmd/root.go
- disable line length linter(lll), to keep it consistent with cosmos-sdk
- one can still use the derivation of mkShell to work with remote shell
@tomtau tomtau closed this as completed in 42f54b3 Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yihuang yihuang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yihuang @leejw51crypto