Problem: no genesis app hash integrity check

[tomtau]

currently app hash is left empty in genesis; and it's unchecked whether the genesis state matches whatever it ends up with.

there are some related issues in Cosmos SDK e.g. cosmos/cosmos-sdk#7020

[leejw51crypto]

started

[leejw51crypto]

in app.go)

func (app *NewApp) InitChain(req abci.RequestInitChain) (res abci.ResponseInitChain) {
 fmt.Println("****************************************************")
 ret := app.BaseApp.InitChain(req)
 var appHash []byte
 if !app.LastCommitID().IsZero() {
 appHash = app.LastCommitID().Hash
 return ret
 } else {
 // $ echo -n '' | sha256sum
 // e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
 emptyHash := sha256.Sum256([]byte{})
 appHash = emptyHash[:]
 }
 return abci.ResponseInitChain{
 ConsensusParams: ret.ConsensusParams,
 Validators: ret.Validators,
 AppHash: appHash,
 }

this override basicapp's InitChain, return apphash of genesis block
but it need high version of comos-sdk, and tendermint

i'll check with stargate

[leejw51crypto]

until, cosmos-sdk, tendermint is updated to latest,
i'll do other task

[leejw51crypto]

because master is updated, i'll merge this code

[leejw51crypto]

done, will submir pr

[tomtau]

as discussed in the PR:

1. app hash field will be removed from genesis: https://github.com/tendermint/tendermint/issues/5238 (so not much value of making an effort of testing it now)
2. cosmos sdk doesn't dump "the app state" in app state, but puts transactions etc. there that need to be applied, i.e. app state still needs to be computed (so one would need to run the initchain also in genesis.json preparation to compute the app hash, which may be a bit redundant: https://github.com/tendermint/tendermint/issues/5238#issuecomment-673403036 )