Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Error in querying block_results of blocks with slashing occurs #95

Closed
calvinaco opened this issue Sep 21, 2020 · 8 comments
Closed

Comments

@calvinaco
Copy link
Contributor

If a block contains a slashing events, the block_results RPC will return the error

{
  "jsonrpc": "2.0",
  "id": -1,
  "error": {
    "code": -32603,
    "message": "Internal error",
    "data": "error marshalling response: cannot encode unregistered type crypto.PublicKey_Ed25519"
  }
}
@tomtau
Copy link
Contributor

tomtau commented Sep 21, 2020

maybe updating SDK -- there were some PRs e.g. cosmos/cosmos-sdk#7147 ?

@leejw51crypto
Copy link
Contributor

yes, it looks old version bug,
New version will display correctly.

@tomtau
Copy link
Contributor

tomtau commented Sep 28, 2020

verified this on the latest master -- bdf5312

I'll try updating SDK once more, as there is some other patch:
cosmos/cosmos-sdk@91ca8ad

@tomtau
Copy link
Contributor

tomtau commented Sep 28, 2020

updated sdk -- still the same.
I opened this issue cosmos/cosmos-sdk#7401

@tomtau
Copy link
Contributor

tomtau commented Sep 28, 2020

@calvinaco it's not only slashing -- also if you delegate (or change the voting power anyhow), it's the same

@leejw51crypto
Copy link
Contributor

is it the same with protobuf?

@tomtau
Copy link
Contributor

tomtau commented Sep 29, 2020

is it the same with protobuf?

I haven't found the exact block_results equivalent in gRPC -- one can "compose" it though, as gRPC exposes different module query interfaces (that are taken from block_results)

@tomtau
Copy link
Contributor

tomtau commented Oct 6, 2020

@calvinaco FYI, this is now fixed in Tendermint master: tendermint/tendermint#5459

tomtau added a commit that referenced this issue Oct 9, 2020
…rs (fixes #95)

Solution: upgraded to the latest master of SDK with the fix
+ cherry-picked the graceful shutdown fix
tomtau added a commit that referenced this issue Oct 9, 2020
…rs (fixes #95)

Solution: upgraded to the latest master of SDK with the fix
+ cherry-picked the graceful shutdown fix
@tomtau tomtau closed this as completed in 60ba96a Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants