Problem: latest v0.44 SDK is not used #643

tomtau · 2021-09-02T02:11:28Z

Solution: bumped SDK + upgraded Go to 1.17

tomtau · 2021-09-02T02:11:37Z

/runsim

github-actions · 2021-09-02T02:11:59Z

Simulation tests started and triggered by /runsim.
Will update here when it succeeds or fails.
Can further check progress here

tomtau · 2021-09-02T02:12:14Z

go.mod

@@ -26,6 +26,103 @@ require (

 )

+require (


this is generated when I ran go mod tidy https://golang.org/doc/go1.17

For the go command to correctly resolve transitive imports using the pruned module graph, the go.mod file for each module needs to include more detail about the transitive dependencies relevant to that module. If a module specifies go 1.17 or higher in its go.mod file, its go.mod file now contains an explicit require directive for every module that provides a transitively-imported package. (In previous versions, the go.mod file typically only included explicit requirements for directly-imported packages.)

codecov · 2021-09-02T02:14:30Z

Codecov Report

Merging #643 (0953ab0) into master (ff47723) will increase coverage by 12.55%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #643       +/-   ##
===========================================
+ Coverage    9.77%   22.32%   +12.55%     
===========================================
  Files          36       70       +34     
  Lines        5721     8131     +2410     
===========================================
+ Hits          559     1815     +1256     
- Misses       5072     5776      +704     
- Partials       90      540      +450

Flag	Coverage Δ
integration_tests	`18.97% <ø> (?)`
unit_tests	`9.77% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
x/nft/keeper/invariants.go	`3.92% <0.00%> (-46.08%)`	⬇️
x/nft/keeper/querier.go	`8.67% <0.00%> (-31.33%)`	⬇️
x/nft/types/msgs.go	`48.14% <0.00%> (-16.86%)`	⬇️
x/nft/client/rest/tx.go	`0.00% <0.00%> (ø)`
x/nft/client/cli/flags.go	`100.00% <0.00%> (ø)`
x/nft/types/events.go	`80.00% <0.00%> (ø)`
x/supply/keeper/grpc_query.go	`50.00% <0.00%> (ø)`
x/supply/types/genesis.pb.go	`1.51% <0.00%> (ø)`
x/supply/types/genesis.go	`0.00% <0.00%> (ø)`
x/nft/module.go	`60.00% <0.00%> (ø)`
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff47723...0953ab0. Read the comment docs.

go.mod

tomtau · 2021-09-02T02:24:35Z

for the dependency stuff: #618

yihuang

LGTM

github-actions · 2021-09-02T02:51:48Z

✅ /runsim simulation test has succeeded 🎉
Can further check here

Problem: latest v0.44 SDK is not used (crypto-org-chain#643) Solution: bumped SDK + upgraded Go to 1.17 * mark offline signing test to be temporarily ignored Problem: golang-cross 1.17 is not yet on dockerhub (crypto-org-chain#645) Solution: revert back to 1.16

Problem: latest v0.44 SDK is not used (#643) Solution: bumped SDK + upgraded Go to 1.17 * mark offline signing test to be temporarily ignored Problem: golang-cross 1.17 is not yet on dockerhub (#645) Solution: revert back to 1.16

Problem: latest v0.44 SDK is not used

9006364

Solution: bumped SDK + upgraded Go to 1.17

tomtau requested review from devashishdxt and leejw51crypto September 2, 2021 02:11

tomtau requested review from calvinaco and yihuang as code owners September 2, 2021 02:11

tomtau commented Sep 2, 2021

View reviewed changes

sonatype-lift bot reviewed Sep 2, 2021

View reviewed changes